fix(desktop-electron): avoid startup loading hang#23307
Draft
aiulms wants to merge 2 commits intoanomalyco:devfrom
Draft
fix(desktop-electron): avoid startup loading hang#23307aiulms wants to merge 2 commits intoanomalyco:devfrom
aiulms wants to merge 2 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Found 1 potential related PR: PR #19281: fix(desktop): add timeout guards to prevent Windows startup hang This PR addresses a similar issue - a desktop startup hang, though on Windows instead of macOS. Both PRs are fixing platform-specific startup loading hangs in the Electron desktop app and likely involve similar root causes or complementary fixes. Note: This is a different PR (not a duplicate of #23307), but addresses the same general problem space. |
github-actions
bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23308
Type of change
What does this PR do?
This fixes an Electron desktop startup hang on macOS where the app can stay on
Just a moment...even after the sidecar is ready.The change does two things:
init-steplistener alive until the loading flow reachesdoneHow did you verify your code works?
I built the patched Electron desktop app locally on macOS arm64 and launched it with a clean local state. Before the change it stayed on the loading window. After the change it opened into the app successfully.
Screenshots / recordings
UI loading fix only. No screenshot attached.
Checklist