chore: add GatewayProxy caBundle to ingress-controller CRDs, pin ADC 0.29.0 - #994
Open
shreemaan-abhishek wants to merge 1 commit into
Open
chore: add GatewayProxy caBundle to ingress-controller CRDs, pin ADC 0.29.0#994shreemaan-abhishek wants to merge 1 commit into
shreemaan-abhishek wants to merge 1 commit into
Conversation
…0.29.0 GatewayProxy grows an optional caBundle on the control plane provider, a PEM-encoded CA used to verify the control plane in place of the system trust store (apache/apisix-ingress-controller#2826). The bundled CRD has to carry the property, otherwise the API server prunes it in a Helm install and the controller never sees it. The bundle reaches the ADC sidecar as caCert, which lands in 0.29.0 (api7/adc#552). Earlier sidecars accept the option and ignore it, so the field would be set while verification still fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Paired chart change for apache/apisix-ingress-controller#2826, which adds an optional
caBundletoGatewayProxy.spec.provider.controlPlane— a PEM-encoded CA used to verify the control plane in place of the system trust store, sotlsVerify: truecan stay on when the control plane uses a self-signed or private CA.Two things are needed here for that to work in a normal Helm install:
crds/apisixic-crds.yaml— the bundled CRD must carry the property, otherwise the API server prunes the unknown field and the controller never receives it.values.yaml— the bundle reaches the ADC sidecar ascaCert, which lands in 0.29.0 (feat(server): support custom tls config per endpoint api7/adc#552). Earlier sidecars accept the option and silently ignore it, so the field would be set while verification still fails.Chart
versiongoes 1.2.2 -> 1.2.3, following #992.appVersionis unchanged: the controller-side change is not released yet, and the CRD property is inert without it.Changes
crds/apisixic-crds.yaml:caBundleoncontrolPlane, plus the CEL rule that rejects a non-PEM value at admission.values.yaml:deployment.adcContainer.image.tag0.27.1 -> 0.29.0.Chart.yaml:version1.2.2 -> 1.2.3.README.md: regenerated withmake helm-docs.Verification
The CRD edit is not hand-written prose — the property and CEL blocks were lifted verbatim from
controller-genoutput so the chart cannot drift in wording or wrapping. Confirmed by parsing both and comparing:The sidecar bump was exercised against the real image rather than assumed. Running
ghcr.io/api7/adc:0.29.0in ingress mode against an HTTPS backend whose certificate is signed by a private CA, replaying the exact request body the controller builds:tlsSkipVerify: false, nocaCertError: unable to verify the first certificatetlsSkipVerify: false+caCertAlso:
Happy to split the ADC bump into its own PR if you would rather keep them separate (as in #987) — I kept them together because neither half delivers the feature alone.