GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49790
Open
kou wants to merge 1 commit intoapache:mainfrom
Open
GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49790kou wants to merge 1 commit intoapache:mainfrom
CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49790kou wants to merge 1 commit intoapache:mainfrom
Conversation
…hare/doc/${PROJECT_NAME}`
|
|
kou
added
CI: Extra: Package: Linux
There was a problem hiding this comment.
Pull request overview
This PR updates Arrow C++’s install configuration to use CMake’s standard documentation install directory variable (CMAKE_INSTALL_DOCDIR) instead of a hard-coded share/doc/${PROJECT_NAME}, improving compatibility with downstream packagers and custom install layouts.
Changes:
- Switch
ARROW_DOC_DIRfrom a static path to${CMAKE_INSTALL_DOCDIR}. - Keep existing documentation-related install rules (LICENSE/NOTICE/README) but route them through the standardized docdir variable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
CMAKE_INSTALL_DOCDIRis the standard variable for install document directory. Packages use this variable to change install document directory.What changes are included in this PR?
Use
CMAKE_INSTALL_DOCDIRinstead of staticshare/doc/${PROJECT_NAME}Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
CMAKE_INSTALL_DOCDIRinstead of staticshare/doc/${PROJECT_NAME}#49789