Skip to content

[CELEBORN-194] [WIP] Adding client side metrics for celeborn#3740

Open
AmandeepSingh285 wants to merge 4 commits into
apache:mainfrom
AmandeepSingh285:adding-client-side-metrics
Open

[CELEBORN-194] [WIP] Adding client side metrics for celeborn#3740
AmandeepSingh285 wants to merge 4 commits into
apache:mainfrom
AmandeepSingh285:adding-client-side-metrics

Conversation

@AmandeepSingh285

@AmandeepSingh285 AmandeepSingh285 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Adding client side metrics for Celeborn via heartbeat to master.

Why are the changes needed?

These changes help increase observability for Celeborn clients.

Does this PR resolve a correctness bug?

  • Yes

Does this PR introduce any user-facing change?

  • Yes

How was this patch tested?

@AmandeepSingh285 AmandeepSingh285 changed the title [CELEBORN-194] WIP Adding client side metrics for celeborn [CELEBORN-194] [WIP] Adding client side metrics for celeborn Jun 15, 2026
@AmandeepSingh285

Copy link
Copy Markdown
Contributor Author

Hi @SteNicholas , @RexXiong could you please help with a high level review on the implementation design for change adding client side metrics.
Thanks!

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.76190% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.55%. Comparing base (b4cb5a0) to head (e43721a).
⚠️ Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
.../org/apache/celeborn/client/LifecycleManager.scala 29.42% 21 Missing and 3 partials ⚠️
...pache/celeborn/client/ChangePartitionManager.scala 0.00% 4 Missing ⚠️
...born/common/protocol/message/ControlMessages.scala 82.36% 0 Missing and 3 partials ⚠️
...n/client/commit/ReducePartitionCommitHandler.scala 0.00% 2 Missing ⚠️
.../apache/celeborn/common/metrics/ClientMetric.scala 50.00% 1 Missing and 1 partial ⚠️
...eleborn/common/metrics/source/AbstractSource.scala 33.34% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3740      +/-   ##
============================================
- Coverage     66.91%   58.55%   -8.35%     
- Complexity        0      311     +311     
============================================
  Files           358      397      +39     
  Lines         21986    27910    +5924     
  Branches       1946     2728     +782     
============================================
+ Hits          14710    16341    +1631     
- Misses         6262    10382    +4120     
- Partials       1014     1187     +173     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant