Fix parallel retrieve cursor check timeout never going quiet#1796
Open
gfphoenix78 wants to merge 1 commit into
Open
Fix parallel retrieve cursor check timeout never going quiet#1796gfphoenix78 wants to merge 1 commit into
gfphoenix78 wants to merge 1 commit into
Conversation
GP_PARALLEL_RETRIEVE_CURSOR_CHECK_TIMEOUT was armed by every DECLARE
PARALLEL RETRIEVE CURSOR but had no path to ever be disabled: the
handler re-armed it unconditionally in the !DoingCommandRead branch,
and no portal-drop path ever called disable_timeout(). The result was
a SIGALRM firing every 10 seconds for the rest of the backend's life
even when no parallel retrieve cursors remained, which interfered
with unrelated code paths (e.g. truncating pg_usleep-based fault
sleeps that tests rely on).
Tighten this in two ways:
- The handler now only re-arms when GetNumOfParallelRetrieveCursors()
is still positive, so the timer naturally quiets after the last
cursor is gone.
- PortalCleanup() proactively calls disable_timeout() when the
last parallel retrieve cursor in this backend is being torn
down, avoiding even the single stray firing that the handler
fallback would otherwise still produce.
gfphoenix78
force-pushed
the
fix-cursor-timer
branch
from
ad60f47 to
018229f
Compare
my-ship-it
reviewed
Jun 3, 2026
my-ship-it
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GP_PARALLEL_RETRIEVE_CURSOR_CHECK_TIMEOUT was armed by every DECLARE PARALLEL RETRIEVE CURSOR but had no path to ever be disabled: the handler re-armed it unconditionally in the !DoingCommandRead branch, and no portal-drop path ever called disable_timeout(). The result was a SIGALRM firing every 10 seconds for the rest of the backend's life even when no parallel retrieve cursors remained, which interfered with unrelated code paths (e.g. truncating pg_usleep-based fault sleeps that tests rely on).
Tighten this in two ways:
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions