fix(products): pass recurring deposit command - #335
Merged
Aman-Mittal merged 1 commit intoAug 18, 2026
Conversation
4 tasks
YinkaMetrics
force-pushed
the
fix/recurring-deposit-command
branch
from
August 14, 2026 19:59
2538e06 to
3f244d3
Compare
Member
|
@YinkaMetrics pls review failing checks |
YinkaMetrics
force-pushed
the
fix/recurring-deposit-command
branch
from
August 17, 2026 18:54
3f244d3 to
1f14709
Compare
Contributor
Author
|
Thanks for flagging this. I’ve replaced the commit with a GPG-signed version; the change set is otherwise unchanged, and the checks are rerunning now. |
YinkaMetrics
force-pushed
the
fix/recurring-deposit-command
branch
from
August 17, 2026 18:56
1f14709 to
e0256c1
Compare
Aman-Mittal
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Read the recurring-deposit transaction command from the route and pass it as the generated API client's third argument. This lets the form submit both
depositandwithdrawalinstead of sending an unsupported null command.The form defaults unknown commands to
deposit, shows the withdrawal title when appropriate, and has focused coverage for both API calls.Closes #278.
Verification