chore(deps): move every @angular/* package to 22.1.0 in lockstep - #451
Merged
Merged
Conversation
The framework packages exact-peer each other, so they cannot move one at a time. All nine go together, pinned exactly so the lockfile lands on 22.1.0 rather than floating to 22.1.3. The lockfile is regenerated rather than patched. npm cannot reach this state incrementally: every path from the current lockfile ends in ERESOLVE, because @angular-architects/native-federation@22.0.6 pins @angular/build to ~22.0.0 and npm will not move it in place. Regenerating resolves with no peer warnings. TypeScript stays at 6.0.3. @angular/compiler-cli@22.1.0 declares typescript ">=6.0 <6.1", so 7.x cannot land with this or after it. No --legacy-peer-deps, no overrides, no resolutions. Closes: apache#442
Contributor
E2E — mocked backend🎭 E2E Tests✅ All green — 339 passed · 0 failed · 0 skipped, across 27 spec files in 6m 56s. By spec file
All 339 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 32754929577 from |
Contributor
E2E — real Fineract🎭 E2E Tests✅ All green — 72 passed · 0 failed · 0 skipped, across 22 spec files in 7m 7s. By spec file
All 72 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 32754929577 from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #442.
All nine
@angular/*packages to 22.1.0 together. Pinned exactly, because^22.1.0floats to 22.1.3 and the issue asks for 22.1.0 in both files. Happy to switch to carets if you would rather.The lockfile is regenerated rather than patched. npm cannot reach this state incrementally:
@angular-architects/native-federation@22.0.6pins@angular/buildto~22.0.0and npm will not move it in place. Detail in #442. No--legacy-peer-deps,overridesorresolutions.Transitives moved within their existing ranges, so
package.jsonis untouched for them:cdk22.1.3,cliandbuild-angular22.1.5,native-federation22.1.1.typescriptstays at 6.0.3 and@ngx-translate/corestays at 17.0.0.Integrity, since that was the concern. npm audit improves: 11 advisories on
main(2 low, 3 moderate, 6 high) down to 7 here (4 moderate, 3 high). One is new,@angular-devkit/build-webpack(moderate).One you should see rather than have me bury it.
@angular/build@22.1.0pullsvite@8.1.5, which pullslightningcss@1.33.0and its eleven platform binaries. Those are MPL-2.0, Category B, and absent frommain.check:licensespasses with no Category X or unclassified, and flags one for review with "the PMC should know it is here".Verified on a clean
npm ciwith no peer warnings:lint,lint:prune,format:checkandtypecheck:e2eclean; Vitest 746 passed; Karma 627 of 627; Playwrightmocked339 andmobile12;check:licensesandcheck:licenses:productionboth exit 0.I cannot close #313 and #316 (superseded by this) or #312 (TypeScript 7.0.2 is outside
@angular/compiler-cli@22.1.0'stypescript ">=6.0 <6.1"). Could you?Follow-up issue for the ngx-translate v18 migration to come.