[security] Redact sensitive config values in startup logs#3486
Conversation
Add key-based sensitive configuration detection for startup logging, including Flink-compatible sensitive key parts and Fluss access key variants. Ensure GlobalConfiguration logs sensitive values as ****** and add tests for the logging path. Closes apache#3485
|
@Prajwal-banakar PTAL |
|
HI @litiliu Thanks for the fix, this looks good to me and i've one small question, the implementation uses substring matching (contains) for all sensitive key parts. Is this intentionally aligned with Flink's behavior? I'm asking because patterns such as token and secret may also match non-sensitive configuration keys. |
@Prajwal-banakar Yes, this is intentional and aligned with Flink's existing behavior. The implementation follows the same semantics as This can lead to conservative masking for keys containing terms like |
|
@luoyuxia please help review |
Summary
GlobalConfigurationlogs startup properties.fs.s3a.access.key,s3.access-key, andfs.oss.accessKeyId.Fixes #3485
Test Plan
mvn -pl fluss-common -Dtest=ConfigurationTest,GlobalConfigurationTest test