Add test coverage and fix lint for GORM domain event listeners

[borinquenkid]

Summary

• Add mock-based Spock coverage for org.grails.datastore.gorm.events (core), which had little to no coverage: DomainEventListener 0%→93% lines/93% branches, AutoTimestampEventListener 84%/61%→98%/83%, DefaultApplicationEventPublisher 0%→95%/81%, ConfigurableApplicationContextEventPublisher 0%→100%
• Remove a confirmed-dead code path in DomainEventListener.invokeEvent: the event-argument-accepting hook branch could never execute since findAndCacheEvent only ever caches zero-argument methods (confirmed by decompiling spring-core's ReflectionUtils.findMethod)
• Deprecate the now-vestigial event parameter on the 8 public 3-arg before*/after* overloads (scheduled for removal in 9.0); the 2-arg overloads are now canonical and onPersistenceEvent calls them directly
• Fix IntelliJ warnings across the package: raw-type parameterization, .equals()→==, a Set.removeAll(List) performance smell, duplicated publishEvent overload bodies deduplicated into a shared method, and an explicit @NonNull contract on supportsEventType's eventType parameter, matching SmartApplicationListener's javadoc ("never null"); only its sibling supportsSourceType's sourceType parameter is @Nullable in Spring 7 — supportsEventType was previously guarding against a null that the framework never actually passes, so the guard is now removed in favor of a documented, fail-fast contract

Test plan

• :grails-datamapping-core:test full suite green
• :grails-datamapping-rx:test full suite green (verifies the rx subclasses still compile/pass against the changed core signatures)
• :grails-datamapping-core:codeStyle / :grails-datamapping-rx:codeStyle — zero Checkstyle/CodeNarc violations
• jacoco coverage reviewed per class before/after

[Copilot]

Pull request overview

This PR strengthens and modernizes the GORM domain event listener infrastructure by adding substantial Spock test coverage, removing a confirmed-dead reflective invocation path, and making small API and lint/IDE-warning cleanups across the org.grails.datastore.gorm.events package (plus corresponding Rx listener adjustments).

Changes:

• Adds new mock-based Spock specs covering DomainEventListener, AutoTimestampEventListener, and the application event publisher implementations.
• Simplifies domain hook invocation by removing a dead “event-argument” hook path and deprecating the now-vestigial 3-arg hook overloads (event parameter).
• Refactors event publishing/listener handling and updates Rx listeners to align with the core changes and reduce IDE/lint warnings.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
grails-datamapping-rx/src/main/groovy/org/grails/gorm/rx/events/MultiTenantEventListener.groovy	Replaces explicit .equals() usage and clarifies source client naming in event handling.
grails-datamapping-rx/src/main/groovy/org/grails/gorm/rx/events/DomainEventListener.groovy	Uses Groovy == for datastore client comparisons in source validation.
grails-datamapping-rx/src/main/groovy/org/grails/gorm/rx/events/AutoTimestampEventListener.groovy	Uses Groovy == for datastore client comparisons in source validation.
grails-datamapping-core/src/test/groovy/org/grails/datastore/gorm/events/DomainEventListenerSpec.groovy	Adds comprehensive unit coverage for domain event listener behavior and hook dispatch.
grails-datamapping-core/src/test/groovy/org/grails/datastore/gorm/events/DefaultApplicationEventPublisherSpec.groovy	Adds tests for listener dispatch and SmartApplicationListener filtering behavior.
grails-datamapping-core/src/test/groovy/org/grails/datastore/gorm/events/ConfigurableApplicationContextEventPublisherSpec.groovy	Adds delegation tests for the application-context-backed event publisher.
grails-datamapping-core/src/test/groovy/org/grails/datastore/gorm/events/AutoTimestampEventListenerConstructionSpec.groovy	Adds construction + scanning behavior tests, plus event dispatch coverage for AutoTimestamp listener.
grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/events/DomainEventListener.java	Removes dead reflective hook path, updates dispatch to call canonical 2-arg hooks, and deprecates 3-arg overloads.
grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/events/DefaultApplicationEventPublisher.groovy	Deduplicates publish paths into a shared dispatch method and tightens listener API generics.
grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/events/ConfigurableApplicationEventPublisher.groovy	Narrows listener API type bound to ApplicationEvent.
grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/events/AutoTimestampEventListener.java	Tightens generics, adjusts disabled-timestamps cleanup, and updates supportsEventType signature/formatting.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[borinquenkid]

Checked this against Spring 7.0.8's actual SmartApplicationListener source: supportsEventType's eventType parameter is documented never null, not @Nullable — it's the sibling supportsSourceType(sourceType) method whose parameter is @Nullable. I'd mixed the two up in the PR description (now corrected). Since nothing in the real dispatch path ever calls supportsEventType(null) (Spring's multicaster and this PR's own DefaultApplicationEventPublisher.dispatch always pass event.getClass()), the @NonNull annotation + fail-fast NPE here is the correct contract, consistent with this PR's theme of removing defensive code for guarantees the framework already provides. Leaving as-is.

[borinquenkid]

Same finding as on the DomainEventListener copy of this method: Spring 7's SmartApplicationListener.supportsEventType's eventType is documented never null (it's supportsSourceType's sourceType that's @Nullable, not this one). The PR description was wrong about which parameter is nullable — fixed now. @NonNull + fail-fast here is intentional and correct; no code change needed.

[borinquenkid]

Same root cause as the two supportsEventType comments above: I mischaracterized the Spring contract in the PR description. SmartApplicationListener.supportsEventType's eventType parameter is documented never null in Spring 7.0.8 — it's supportsSourceType's sourceType param that's actually @Nullable. So this spec correctly asserts the fail-fast NPE, matching the real (non-nullable) contract rather than a nullable one. Description corrected; test left as-is.

[codecov]

Codecov Report

❌ Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.2015%. Comparing base (506228b) to head (dcdb614).
⚠️ Report is 277 commits behind head on 8.1.x.

Files with missing lines	Patch %	Lines
...ils/gorm/rx/events/MultiTenantEventListener.groovy	66.6667%	0 Missing and 2 partials ⚠️
...g/grails/gorm/rx/events/DomainEventListener.groovy	50.0000%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##                8.1.x     #16151        +/-   ##
==================================================
+ Coverage     52.8254%   53.2015%   +0.3760%     
- Complexity      18871      19402       +531     
==================================================
  Files            2079       2080         +1     
  Lines           97207      98986      +1779     
  Branches        16873      17358       +485     
==================================================
+ Hits            51350      52662      +1312     
- Misses          38446      38777       +331     
- Partials         7411       7547       +136     

Files with missing lines	Coverage Δ
...astore/gorm/events/AutoTimestampEventListener.java	94.0909% <100.0000%> (+5.8556%)	⬆️
...orm/events/DefaultApplicationEventPublisher.groovy	93.3333% <100.0000%> (+45.7143%)	⬆️
...ils/datastore/gorm/events/DomainEventListener.java	95.7983% <100.0000%> (+19.6078%)	⬆️
...s/gorm/rx/events/AutoTimestampEventListener.groovy	100.0000% <100.0000%> (ø)
...g/grails/gorm/rx/events/DomainEventListener.groovy	83.3333% <50.0000%> (ø)
...ils/gorm/rx/events/MultiTenantEventListener.groovy	93.9394% <66.6667%> (ø)

... and 89 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

Suppressed comments (1)

grails-datamapping-core/src/main/groovy/org/grails/datastore/gorm/events/DefaultApplicationEventPublisher.groovy:48

• DefaultApplicationEventPublisher.publishEvent(Object) always wraps the argument in a PayloadApplicationEvent, even when the caller passes an ApplicationEvent instance. This diverges from Spring’s ApplicationEventPublisher behavior (publish ApplicationEvent as-is, otherwise wrap as a payload) and can change listener filtering/dispatch if Java code calls the Object overload with an ApplicationEvent-typed-as-Object.

    @Override
    void publishEvent(Object event) {
        dispatch(new PayloadApplicationEvent<Object>(this, event))
    }

[testlens-app]

🚨 TestLens detected 1 failed test 🚨

Here is what you can do:

1. Inspect the test failures carefully.
2. If you are convinced that some of the tests are flaky, you can mute them below.
3. Finally, trigger a rerun by checking the rerun checkbox.

Test Summary

CI / Functional Tests (Java 21, indy=false, shard 1) > :grails-test-examples-gsp-sitemesh3:integrationTest

Test	Runs	Flakiness
EndToEndSpec > async multiple levels of layouts	❌	1% 🟡

🏷️ Commit: dcdb614
▶️ Tests: 62600 executed
⚪️ Checks: 78/78 completed

Test Failures

EndToEndSpec > async multiple levels of layouts (:grails-test-examples-gsp-sitemesh3:integrationTest in CI / Functional Tests (Java 21, indy=false, shard 1))

Condition not satisfied:

pageSource == """<html><head><title>Decorated Base - Dialog - This is the title</title><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head> <body><h1>Hello</h1><div id="base"><div id="dialog">body text</div></div> </body></html>"""
|          |
|          false
|          Strings too large to calculate edit distance.
<html lang="en"><head><title>HTTP Status 500 – Internal Server Error</title><style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style></head><body><h1>HTTP Status 500 – Internal Server Error</h1></body></html>

	at EndToEndSpec.async multiple levels of layouts(EndToEndSpec.groovy:107)

expected	actual
<html><head><title>Decorated Base - Dialog - This is the title</title><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head>	<html lang="en"><head><title>HTTP Status 500 – Internal Server Error</title><style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style></head><body><h1>HTTP Status 500 – Internal Server Error</h1></body></html>
<body><h1>Hello</h1><div id="base"><div id="dialog">body text</div></div>
</body></html>

Muted Tests

Select tests to mute in this pull request:

• EndToEndSpec > async multiple levels of layouts

Reuse successful test results:

• ♻️ Only rerun the tests that failed or were muted before

Click the checkbox to trigger a rerun:

• Rerun jobs

---

Learn more about TestLens at testlens.app.