HTTPCLIENT-2418 - Fix SimpleBody default charset handling for JSON content#823
Merged
arturobernalg merged 1 commit intoapache:masterfrom Apr 18, 2026
Merged
Conversation
ok2c
reviewed
Apr 17, 2026
| return charset; | ||
| } | ||
| final String mimeType = contentType.getMimeType(); | ||
| if (contentType.isSameMimeType(ContentType.APPLICATION_JSON) |
Member
There was a problem hiding this comment.
@arturobernalg Oh, god. This is ugly. Just use always UTF-8 and be done with it.
… content.Use UTF-8 instead of US-ASCII when no charset parameter is present.
arturobernalg
force-pushed
the
HTTPCLIENT-2418
branch
from
bc00e36 to
6d7bd08
Compare
ok2c
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimpleBody currently falls back to ASCII when Content-Type is application/json without an explicit charset, which breaks UTF-8 payloads.