Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyiceberg/io/pyarrow.py
Original file line number Diff line number Diff line change
Expand Up @@ -2657,8 +2657,12 @@ def write_parquet(task: WriteTask) -> DataFile:
fos, schema=arrow_table.schema, store_decimal_as_integer=True, **parquet_writer_kwargs
) as writer:
writer.write(arrow_table, row_group_size=row_group_size)

with io.new_input(file_path).open() as input_stream:
parquet_metadata = pq.read_metadata(input_stream)

statistics = data_file_statistics_from_parquet_metadata(
parquet_metadata=writer.writer.metadata,
parquet_metadata=parquet_metadata,
stats_columns=compute_statistics_plan(file_schema, table_metadata.properties),
parquet_column_mapping=parquet_path_to_id_mapping(file_schema),
)
Expand Down
29 changes: 29 additions & 0 deletions tests/io/test_pyarrow.py
Original file line number Diff line number Diff line change
Expand Up @@ -3045,6 +3045,35 @@ def test_write_file_rejects_timestamptz_to_timestamp(tmp_path: Path) -> None:
list(write_file(io=PyArrowFileIO(), table_metadata=table_metadata, tasks=iter([task])))


def test_write_file_reads_parquet_metadata(tmp_path: Path) -> None:
from pyiceberg.table import WriteTask

table_schema = Schema(NestedField(1, "id", IntegerType(), required=False))
arrow_data = pa.table({"id": pa.array([1, 2, 3], type=pa.int32())})

table_metadata = TableMetadataV2(
location=f"file://{tmp_path}",
last_column_id=1,
format_version=2,
schemas=[table_schema],
partition_specs=[PartitionSpec()],
)

task = WriteTask(
write_uuid=uuid.uuid4(),
task_id=0,
record_batches=arrow_data.to_batches(),
schema=table_schema,
)

with patch("pyiceberg.io.pyarrow.pq.read_metadata", wraps=pq.read_metadata) as mock_read_metadata:
data_files = list(write_file(io=PyArrowFileIO(), table_metadata=table_metadata, tasks=iter([task])))

assert mock_read_metadata.called
assert len(data_files) == 1
assert data_files[0].record_count == 3


def test__to_requested_schema_timestamps(
arrow_table_schema_with_all_timestamp_precisions: pa.Schema,
arrow_table_with_all_timestamp_precisions: pa.Table,
Expand Down