Skip to content

refactor(shard): drop journal generic, metrics scrape, poll cursor - #3914

Open
numinnex wants to merge 4 commits into
masterfrom
fix_cleanup_issues_nextnextnext
Open

refactor(shard): drop journal generic, metrics scrape, poll cursor#3914
numinnex wants to merge 4 commits into
masterfrom
fix_cleanup_issues_nextnextnext

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 18, 2026
@numinnex

Copy link
Copy Markdown
Contributor Author

merge after #3911

@numinnex
numinnex force-pushed the fix_cleanup_issues_nextnextnext branch from 258c662 to d9284e3 Compare August 18, 2026 12:23
@numinnex numinnex changed the title refactor(consensus): single restore constructor + wedge/replay/ack fixes refactor(shard): drop journal generic, metrics scrape, poll cursor Aug 18, 2026
@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 53.30882% with 254 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.99%. Comparing base (6043d19) to head (d9284e3).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
core/server/src/partition_reconciler.rs 0.57% 174 Missing ⚠️
core/metadata/src/impls/recovery.rs 21.42% 22 Missing ⚠️
core/simulator/src/lib.rs 42.85% 16 Missing ⚠️
core/shard/src/lib.rs 46.42% 15 Missing ⚠️
core/server/src/bootstrap.rs 92.45% 7 Missing and 1 partial ⚠️
core/configs/src/server_config/cluster.rs 81.48% 5 Missing ⚠️
core/server_common/src/executor.rs 86.11% 5 Missing ⚠️
core/server/src/dispatch.rs 40.00% 3 Missing ⚠️
core/consensus/src/plane_helpers.rs 50.00% 2 Missing ⚠️
core/partitions/src/types.rs 87.50% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #3914       +/-   ##
=============================================
- Coverage     83.69%   57.99%   -25.70%     
  Complexity     1358     1358               
=============================================
  Files          1212     1211        -1     
  Lines        165138   153050    -12088     
  Branches     132612   120649    -11963     
=============================================
- Hits         138215    88766    -49449     
- Misses        23274    60839    +37565     
+ Partials       3649     3445      -204     
Components Coverage Δ
Rust Core 51.46% <53.30%> (-32.99%) ⬇️
Java SDK 66.67% <ø> (ø)
C# SDK 75.04% <ø> (-1.45%) ⬇️
Python SDK 90.00% <ø> (ø)
PHP SDK 84.48% <ø> (ø)
Node SDK 95.94% <ø> (+0.09%) ⬆️
Go SDK 68.32% <ø> (ø)
Files with missing lines Coverage Δ
core/configs/src/common/server.rs 100.00% <100.00%> (ø)
core/configs/src/server_config/defaults.rs 100.00% <100.00%> (ø)
core/consensus/src/fatal.rs 0.00% <ø> (ø)
core/consensus/src/impls.rs 73.46% <100.00%> (-17.54%) ⬇️
core/journal/src/lib.rs 25.00% <ø> (ø)
core/journal/src/prepare_journal.rs 41.84% <ø> (-48.61%) ⬇️
core/metadata/src/impls/metadata.rs 70.10% <100.00%> (-16.50%) ⬇️
core/partitions/src/iggy_index_reader.rs 34.17% <ø> (-59.12%) ⬇️
core/partitions/src/iggy_partition.rs 57.76% <100.00%> (-29.14%) ⬇️
core/partitions/src/journal.rs 70.16% <ø> (-19.24%) ⬇️
... and 31 more

... and 449 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@numinnex numinnex changed the title refactor(shard): drop journal generic, metrics scrape, poll cursor refactor(shard): drop journal generic, metrics scrape, poll cursor Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant