Skip to content

ci(rust): don't fail when a DAG scope matches no tests - #3943

Merged
hubcio merged 3 commits into
masterfrom
ci/dag-do-not-fail-empty
Aug 21, 2026
Merged

ci(rust): don't fail when a DAG scope matches no tests#3943
hubcio merged 3 commits into
masterfrom
ci/dag-do-not-fail-empty

Conversation

@chengxilo

@chengxilo chengxilo commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Related to: #3935, as this is why its CI fails.

The rail-computed scope for a PR that only touches bdd/rust is a single
crate whose test targets are all required-features = ["bdd"]. Nothing
in this task builds them, so package(bdd) matches zero tests and
nextest's default --no-tests=fail reds a run that broke nothing.

Use warn rather than pass so the other cause of a zero-match filter,
a crate rename leaving package(...) pointing at nothing, still leaves a
line in the log. The unfiltered branch keeps the default, where zero
tests means a broken checkout rather than an empty scope.

Related to: #3935, as this is why its CI fails.

The rail-computed scope for a PR that only touches bdd/rust is a single
  crate whose test targets are all `required-features = ["bdd"]`. Nothing
  in this task builds them, so `package(bdd)` matches zero tests and
  nextest's default `--no-tests=fail` reds a run that broke nothing.

  Use `warn` rather than `pass` so the other cause of a zero-match filter,
  a crate rename leaving `package(...)` pointing at nothing, still leaves a
  line in the log. The unfiltered branch keeps the default, where zero
  tests means a broken checkout rather than an empty scope.
@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.75%. Comparing base (0f48afd) to head (5310f54).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3943      +/-   ##
============================================
- Coverage     83.88%   83.75%   -0.13%     
  Complexity     1358     1358              
============================================
  Files          1212     1212              
  Lines        166843   166845       +2     
  Branches     134304   134433     +129     
============================================
- Hits         139948   139734     -214     
- Misses        23257    23322      +65     
- Partials       3638     3789     +151     
Components Coverage Δ
Rust Core 84.59% <ø> (-0.06%) ⬇️
Java SDK 66.67% <ø> (ø)
C# SDK 74.99% <ø> (-1.56%) ⬇️
Python SDK 90.13% <ø> (ø)
PHP SDK 84.48% <ø> (ø)
Node SDK 95.84% <ø> (-0.10%) ⬇️
Go SDK 68.32% <ø> (ø)
see 72 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chengxilo chengxilo changed the title ci/dag do not fail empty ci(rust): don't fail when a DAG scope matches no tests Aug 21, 2026
@hubcio
hubcio merged commit 127a33c into master Aug 21, 2026
103 checks passed
@hubcio
hubcio deleted the ci/dag-do-not-fail-empty branch August 21, 2026 09:27
@github-actions github-actions Bot removed the S-waiting-on-review PR is waiting on a reviewer label Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants