KNOX-3428: Bump Spring to 6.2.19 and add HashiCorp Vault alias service integration tests - #1367
Merged
Merged
Conversation
…e integration tests
Test Results 4 files 4 suites 14s ⏱️ Results for commit 7040009. |
moresandeep
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3428 - Bump Spring to 6.2.19 and add HashiCorp Vault alias-service integration tests
What changes were proposed in this pull request?
tests/test_knox_hashicorp_vault_alias.py: round-trips an alias through the admin alias REST API and verifies the secret directly in Vault, plus delete-removal and an unauthenticated-401 check.compose/docker-compose.hashicorp-vault.yml+compose/hashicorp-vault/{gateway-site,admin}.xml: dev-mode Vault (hashicorp/vault:1.17) and Knox on a Vault-backed RemoteAliasService. gateway-site.xml also setsgateway.service.tokenstate.impl=DefaultTokenStateServiceto avoid an init-time alias read that would make Vault a fatal startup dependency.compose/docker-compose.yml + tests.yml: base run ignores the suite; CI runs it and uploads test-results-hashicorp-vault.xml.How was this patch tested?
Ran the suite locally via Docker Compose (
up -d knox vault→run --rm tests pytest -v test_knox_hashicorp_vault_alias.py): 3 passed.test_alias_write_is_stored_in_vaultreads the secret straight from Vault's HTTP API and asserts the exact value, confirming the write reached Vault (not just the local keystore fallback).pylint *.pyrated 10.00/10.Integration Tests
Added
test_knox_hashicorp_vault_alias.py. The Vault dev image boots in seconds, so it runs on every PR (not label-gated).