Remove the JUnit 4 leftovers - #941
Merged
Merged
Conversation
The sample consumer is not a reactor module and nothing references it, so it has never been compiled against the TCK it demonstrates.
The four junit:junit exclusions no longer exclude anything: wagon-provider-test stopped declaring junit, and stripping all four leaves junit:junit absent from every resolved tree. Do not restore them with the managed version.
slachiewicz
force-pushed
the
drop-junit4-leftovers
branch
from
August 18, 2026 21:04
662ef22 to
cb2c1a4
Compare
slachiewicz
marked this pull request as ready for review
August 18, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #939 and #940 from
wagon-3.x, where this landed first.The developer guide described the JUnit 3 and 4 shape in four places:
wagon-provider-testdragging in JUnit 3-style
PlexusTestCase,WagonTestCase extends PlexusTestCase,getWagon()calling
lookup(Wagon.ROLE, getProtocol()), and the TCK as a JUnit 4 suite wired with@RunWith(Suite.class). None of that has been true since #936. The guide now also namesjunit-platform-suiteas a dependency a provider has to add for@Suite; without it the suiteclass compiles but selects nothing.
The four
junit:junitexclusions no longer exclude anything: removing all four leaves thereactor resolving the same single
junit:junit:4.13.2:test, inwagon-scm, that it resolvestoday. That one is why the managed
junit:junitversion stays, since it is what holds themaven-scm-testtransitive at 4.13.2 rather than 4.12.The
plexus-container-defaultexclusion inwagon-scmis untouched, and its comment now sayswhat it actually does:
maven-scm1.11.1 manages that artifact at 1.0-alpha-9, which ships thesame
PlexusContainer,DefaultPlexusContainerandPlexusTestCaseclass names asorg.eclipse.sisu.plexus, and also drags inclassworlds1.1-alpha-2 andjunitat runtimescope.
wagon-tcks/wagon-tck-http/sample-tck-consumergoes: not a reactor module, nothing referencesit, pinned at
wagon-http-lightweight1.0-beta-6, and itsTestSuiteis still@RunWith(Suite.class), so the one worked example of consuming the TCK shows the wiring theguide warns against.
Two changes from the
wagon-3.xcommits do not apply here.TestPrompterand thewagon-sshtest
components.xmlexist only on that line, so their comment fixes have nothing to land on.Verified:
dependency:treeover the whole reactor is unchanged, and per-module<testcase>counts are unchanged against
0962d3e6.This change was created with AI assistance.