Skip to content

Remove the JUnit 4 leftovers - #941

Merged
slachiewicz merged 2 commits into
masterfrom
drop-junit4-leftovers
Aug 19, 2026
Merged

Remove the JUnit 4 leftovers#941
slachiewicz merged 2 commits into
masterfrom
drop-junit4-leftovers

Conversation

@slachiewicz

@slachiewicz slachiewicz commented Aug 18, 2026

Copy link
Copy Markdown
Member

Forward-port of #939 and #940 from wagon-3.x, where this landed first.

The developer guide described the JUnit 3 and 4 shape in four places: wagon-provider-test
dragging in JUnit 3-style PlexusTestCase, WagonTestCase extends PlexusTestCase, getWagon()
calling lookup(Wagon.ROLE, getProtocol()), and the TCK as a JUnit 4 suite wired with
@RunWith(Suite.class). None of that has been true since #936. The guide now also names
junit-platform-suite as a dependency a provider has to add for @Suite; without it the suite
class compiles but selects nothing.

The four junit:junit exclusions no longer exclude anything: removing all four leaves the
reactor resolving the same single junit:junit:4.13.2:test, in wagon-scm, that it resolves
today. That one is why the managed junit:junit version stays, since it is what holds the
maven-scm-test transitive at 4.13.2 rather than 4.12.

The plexus-container-default exclusion in wagon-scm is untouched, and its comment now says
what it actually does: maven-scm 1.11.1 manages that artifact at 1.0-alpha-9, which ships the
same PlexusContainer, DefaultPlexusContainer and PlexusTestCase class names as
org.eclipse.sisu.plexus, and also drags in classworlds 1.1-alpha-2 and junit at runtime
scope.

wagon-tcks/wagon-tck-http/sample-tck-consumer goes: not a reactor module, nothing references
it, pinned at wagon-http-lightweight 1.0-beta-6, and its TestSuite is still
@RunWith(Suite.class), so the one worked example of consuming the TCK shows the wiring the
guide warns against.

Two changes from the wagon-3.x commits do not apply here. TestPrompter and the wagon-ssh
test components.xml exist only on that line, so their comment fixes have nothing to land on.

Verified: dependency:tree over the whole reactor is unchanged, and per-module <testcase>
counts are unchanged against 0962d3e6.

This change was created with AI assistance.

The sample consumer is not a reactor module and nothing references it, so it has
never been compiled against the TCK it demonstrates.
@slachiewicz slachiewicz added maintenance documentation Improvements or additions to documentation labels Aug 18, 2026
The four junit:junit exclusions no longer exclude anything: wagon-provider-test
stopped declaring junit, and stripping all four leaves junit:junit absent from
every resolved tree. Do not restore them with the managed version.
@slachiewicz
slachiewicz force-pushed the drop-junit4-leftovers branch from 662ef22 to cb2c1a4 Compare August 18, 2026 21:04
@slachiewicz
slachiewicz marked this pull request as ready for review August 18, 2026 21:05
@slachiewicz
slachiewicz merged commit 4c4b84f into master Aug 19, 2026
12 checks passed
@slachiewicz
slachiewicz deleted the drop-junit4-leftovers branch August 19, 2026 04:25
@github-actions github-actions Bot added this to the 4.0.0-M1 milestone Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant