Conversation
Add RFC proposing to remove `.trim()` from `normalize_path` so that whitespace within path components is preserved. The current behavior silently rewrites paths with leading/trailing whitespace to different objects, violating the documented API contract.
dosubot
Bot
added
size:L
Member
|
Need to fix the typos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4101, #6577.
Rationale for this change
To improve security and clarify behaviors.
What changes are included in this PR?
Add RFC proposing to remove
.trim()fromnormalize_pathso that whitespace within path components is preserved. The current behavior silently rewrites paths with leading/trailing whitespace to different objects, violating the documented API contract.Are there any user-facing changes?
Yes, path normalization affects most users, services and bindings.
AI Usage Statement
Claude Opus 4.6 made research and a draft.