[2.x] Merge shell tests into the Java CI pipeline#1121
Merged
Conversation
rzo1
changed the title
Contributor
|
@rzo1 Can you rebase this PR (2.x) pls? |
Run the shell (bats/Pester) tests as a stage after the regular build in maven.yml instead of in a separate workflow that rebuilt OpenNLP from scratch on each OS. The binary distribution is pure-Java and platform-independent, so it is now built once (Ubuntu/JDK 17), uploaded as an artifact, and reused by the per-OS shell-test jobs via needs/download-artifact. This removes three redundant Maven builds per run. actions/upload-artifact and actions/download-artifact are in the actions/* namespace, which is automatically allowed under the ASF GitHub Actions policy, so no INFRA allowlist change is required.
rzo1
force-pushed
the
ci-merge-shell-tests-into-build-2x
branch
from
7b6d64b to
48ebc84
Compare
Contributor
Author
|
Rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Runs the shell (bats/Pester) tests as a stage after the regular build in
maven.yml, and removes the standaloneshell-tests.ymlworkflow. (Backport of the same change foropennlp-2.x.)Why
Previously the distribution was built 12× per run: 9 in
maven.yml(3 OS × 3 JDK) plus 3 more inshell-tests.yml(one per OS), purely to produce the tarball the shell tests run against.The binary distribution is pure-Java and platform-independent, so it is now:
buildjob (Ubuntu / JDK 17) and uploaded viaactions/upload-artifact.needs: build) viaactions/download-artifact, which then extract and run bats (Ubuntu/macOS) / Pester (Windows).This drops the 3 redundant Maven builds per run.
ASF policy note
actions/upload-artifactandactions/download-artifactare in theactions/*namespace, which is automatically allowed under the ASF GitHub Actions policy (alongsideapache/*andgithub/*). No INFRA allowlist change is required.