Fix the method for verifying the existence of the appkey#6425
Closed
KANLON wants to merge 2 commits into
Closed
Conversation
1 task
Contributor
|
pls add my wechat: aias00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6422
The
GET /appAuth/updateSkendpoint always fails validation with the errorupdateSk.appKey: app key not existed, regardless of whether the providedappKeyactually exists in the database.Root cause: The
@Existedvalidation on theappKeyparameter usesAppKeyProvider, whoseexisted()method callsappAuthMapper.existed(key). However,AppAuthMapper.existed()queries theid(primary key) column instead of theapp_keycolumn:Since the passed
appKeyvalue is checked against theidcolumn, the query never matches, so the validation always fails.Fix: In
AppKeyProvider.existed(), callappAuthMapper.appKeyExisted(key)instead ofappAuthMapper.existed(key).Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true.