Skip to content

chore: update validation workflow and scripts for README and manifest versions - #78

Open
birosrichard wants to merge 3 commits into
mainfrom
feat/update-validation-workflow
Open

chore: update validation workflow and scripts for README and manifest versions#78
birosrichard wants to merge 3 commits into
mainfrom
feat/update-validation-workflow

Conversation

@birosrichard

@birosrichard birosrichard commented Aug 4, 2026

Copy link
Copy Markdown

Extend generate_agents.py to check README and manifest versions

agents/AGENTS.md is generated and marketplace.json is validated in CI, but two other hand-maintained surfaces had no guard at all, and both had already drifted:

  • gemini-extension.json was on 1.0.0, while plugin.json and marketplace.json were on 2.0.0. Fixed here.
  • The README skills table and its Skills-N badge are updated by hand. Nothing stops a new skill from landing without them.

The script already walks these files, so it now checks them too.

Changes

  • validate_readme compares the skill names in the ## Skills table against skills/*/SKILL.md in both directions, and checks the badge count (URL and alt text). Only names and counts, not the prose: the table copy is hand-written and better than the SKILL.md descriptions, so it stays human.
  • validate_versions — asserts one shared version across plugin.json, gemini-extension.json, marketplace.json metadata, and each per-plugin version in marketplace.json (those are what users actually install).
  • All checks now run before exiting, so one CI run reports everything that needs fixing instead of one problem per round.
  • Workflow paths now include README.md, plugin.json and gemini-extension.json; otherwise, a PR touching only those files would skip validation entirely.

This is part of the #75

@birosrichard birosrichard self-assigned this Aug 4, 2026
@birosrichard birosrichard added the t-web Issues with this label are in the ownership of the web team. label Aug 4, 2026
@marekh19

marekh19 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@claude /code-review

@marekh19 marekh19 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but since it's about trusting these guards: the "not covered by any plugin" loop (lines 108–116) has been dead since apify-actor-commands got "source": "./". lstrip is a character-set strip, so "./".lstrip("./") is "", and every skill path starts with "".

Comment thread scripts/generate_agents.py
Comment thread scripts/generate_agents.py Outdated
Comment thread scripts/generate_agents.py
@webrdaniel webrdaniel linked an issue Aug 10, 2026 that may be closed by this pull request
5 tasks
@birosrichard

Copy link
Copy Markdown
Author

Unrelated to this PR, but since it's about trusting these guards: the "not covered by any plugin" loop (lines 108–116) has been dead since apify-actor-commands got "source": "./". lstrip is a character-set strip, so "./".lstrip("./") is "", and every skill path starts with "".

#79

Created a follow-up issue :)

@birosrichard
birosrichard requested a review from marekh19 August 10, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-web Issues with this label are in the ownership of the web team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generate every official and community Skill inventory

3 participants