test: poll the first fetch in the shared RQ in-progress test - #1105
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1105 +/- ##
==========================================
+ Coverage 92.65% 92.68% +0.02%
==========================================
Files 51 51
Lines 3445 3445
==========================================
+ Hits 3192 3193 +1
+ Misses 253 252 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
August 26, 2026 11:57
Pijukatel
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_shared_is_finished_false_while_request_in_progressfailed on an unrelated PR's CI(run 32959613011) with
assert None is not None: its firstfetch_next_request()came back empty.In shared mode that is expected, not a client defect. The fetch goes through
list_and_lock_head, which iseventually consistent, so a just-committed request can be missing from the head for a moment (#808). The crawler
tolerates it because
is_finished()still reportsFalsewhile the request is unhandled, so it retries instead ofshutting down.
Every other shared-mode read in the module already polls with
poll_until_condition, as the note at the top of thefile prescribes; this one call site did not. It now polls with the same
timeout=30, backoff_factor=2used by theother shared-only tests in the file (the
rq_poll_timeoutfixture is unavailable here, since the test opens its ownqueue instead of using the parametrized fixture).
✍️ Drafted by Claude Code