Rockchip-rv1106 family: add to group only if group doesn't exist yet#9689
Rockchip-rv1106 family: add to group only if group doesn't exist yet#9689vidplace7 wants to merge 1 commit intoarmbian:mainfrom
Conversation
Some other packages add these groups (before the family_tweaks are run) causing build failures. We should only create them when they do not already exist.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
This is identical to PR #8479 but applied to the
rockchip-rv1106family. (Please merge that one too! 🙏)Some other packages may add the
i2c/gpiogroups before the family_tweaks are run, causing build failures when they are included.We should only create them when they do not already exist. This PR does exactly that.
How Has This Been Tested?
i2c-toolsvia Extension) now works as expected.Checklist:
Summary by CodeRabbit