Feature: file type grouping for NISAR scene files list#2666
Open
SpicyGarlicAlbacoreRoll wants to merge 12 commits into
Open
Feature: file type grouping for NISAR scene files list#2666SpicyGarlicAlbacoreRoll wants to merge 12 commits into
SpicyGarlicAlbacoreRoll wants to merge 12 commits into
Conversation
… into yoreley/finish-files-list-grouping
…anels - Render NISAR scene files grouped by product type using the existing grouping from product.service, with ungrouped files (main science HDF5, Bin File) listed at the top - Map ISO Metadata XML to Metadata; QA Summary CSV, QA Report PDF and QA Statistics HDF5 to Documentation; remove the Data group so the main HDF5 stays ungrouped - Guard against empty product lists and missing selected scene when rendering the files list - Fix null scene crash in nisarSubqueryCriteria - Keep the flat file list for non-NISAR datasets
Group NISAR scene files into collapsible panels by product type. The main science HDF5 stays ungrouped at the top of the list. Empty groups are not rendered. Non-NISAR datasets keep the existing flat list. Co-authored-by: Kim Fairbanks <SpicyGarlicAlbacoreRoll@users.noreply.github.com>
- Remove stale hardcoded white expansion panel header background that rendered as unreadable white blocks in dark mode - Let file group panel headers use the globally themed expansion panel styles and blend the panel body into the file list - Use singular/plural file count label in group headers
- Fixed header height so panels do not grow when expanded, following the filters accordion pattern - Remove expansion panel body padding and expanded spacing so grouped files align and stay compact with the ungrouped list - Transparent themed headers readable in both light and dark modes
Expanded group headers pick up the themed panel background so open groups keep their title visible; collapsed headers stay transparent
… into yoreley/finish-kim-2666 # Conflicts: # src/app/components/results-menu/scene-files/scene-files.component.html # src/app/components/results-menu/scene-files/scene-files.component.ts
Contributor
|
No grouping functionality is provided in the add file by type menu above the scene list view. This doesn't have to be addressed in this PR, but it did seem that tyler was super dissapointed by the current state of it with NISAR. Also, is there a reason for having the related data section external to the accordion menu? Not being able to collapse it creates an inconsistent UX. Similarly, the HDF5 file being listed at the top is also slightly inconsistent because there isn't much to immediately indicate to the viewer that it is a file and not a section until the viewer glances over the icons on the right side. I might instead put it in an accordion menu that is open by default. |
lllarsen
reviewed
Jul 17, 2026
Contributor
There was a problem hiding this comment.
Is it possible to accomplish these changes to theming utilizing style tokens?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO