fix: validate native TypeScript with TypeScript 6#962
Closed
longlho wants to merge 1 commit into
Closed
Conversation
longlho
force-pushed
the
codex/ts6-validator-repo-attrs
branch
3 times, most recently
from
July 14, 2026 18:24
3ba9c66 to
fc9675e
Compare
longlho
force-pushed
the
codex/ts6-validator-repo-attrs
branch
from
July 14, 2026 19:30
fc9675e to
24c8273
Compare
longlho
marked this pull request as ready for review
July 14, 2026 19:53
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
longlho
added a commit
to formatjs/formatjs
that referenced
this pull request
Jul 14, 2026
## Summary - use the official TypeScript 7.0.2 compiler through `rules_ts` - patch the root `typescript` import to delegate the classic Node API to `@typescript/typescript6`, while keeping native TypeScript 7 for `tsc` - patch Vue's declaration import and supply the type-only peers required by `ts-jest` - patch `rules_ts` so its option validator can use the TypeScript 6 compatibility runtime; the upstream fix is aspect-build/rules_ts#962 - keep all Bazel dependencies on root `//:node_modules` labels and regenerate the lock metadata ## Test plan - `bazel build //packages/cli-lib:pkg //packages/ts-transformer:pkg` - focused `cli-lib` and `ts-transformer` unit, typecheck, package export, package JSON, and internal-import tests - `bazel run @npm_typescript//:tsc -- --version` - `bazel run -c opt //:gazelle` - `pnpm install --lockfile-only --offline --frozen-lockfile --trust-lockfile --ignore-scripts` - `bazel mod deps --lockfile_mode=error` - focused oxfmt, buildifier, oxlint, ast-grep, and codescythe checks --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Long Ho <holevietlong@gmail.com>
thesayyn
pushed a commit
that referenced
this pull request
Jul 18, 2026
Close #962 which had an alternative approach. Ref #950 or #967 which do all validation (not only >=7.x) this way in rules_ts 4.x ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes `ts_project` attribute vs tsconfig validation for ts v7+ is now done using `tsc --showConfig`. This may catch additional validation errors not previously found such as when tsconfigs extend from npm packages. ### Test plan - Covered by existing test cases - New test cases added
Member
|
I hope this was accomplished with #969 - please let me know if anything is missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are visible to end-users: yes
Native TypeScript builds now run
ts_projectoption validation through a companion repository containing an exact classic TypeScript 6 release. The native compiler repository keeps its public:validatorlabel and delegates to that companion.validator_ts_versionandvalidator_ts_integritylet consumers pin the validator without adding a second package to the compiler repository'snode_modulestree.Test plan
bazel test --lockfile_mode=error --distdir=/private/tmp //ts/...bazel test --lockfile_mode=error --distdir=/private/tmp //:validator_version_testfrome2e/external_depbazel build --lockfile_mode=error --distdir=/private/tmp @npm_typescript-7_validator//:validatorfrome2e/external_dep