refactor: remove the underlying rule ts_project(extends) attribute and always pass ts_config() - #968
Merged
Conversation
jbedard
force-pushed
the
rm-ts_project-extends
branch
2 times, most recently
from
July 31, 2026 01:55
9ed7b3b to
099d178
Compare
Member
Author
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 099d1785c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jbedard
force-pushed
the
rm-ts_project-extends
branch
2 times, most recently
from
July 31, 2026 02:29
38bbfdc to
4986c2f
Compare
jbedard
marked this pull request as ready for review
July 31, 2026 02:29
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
acozzette
reviewed
Jul 31, 2026
acozzette
approved these changes
Jul 31, 2026
…d always pass ts_config()
jbedard
force-pushed
the
rm-ts_project-extends
branch
from
July 31, 2026 06:34
4986c2f to
d121b67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are visible to end-users: no
Test plan