-
Notifications
You must be signed in to change notification settings - Fork 4
Epoch orchestration layer #427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yacovm
wants to merge
1
commit into
main
Choose a base branch
from
orchestration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,300 @@ | ||
| // Copyright (C) 2019-2025, Ava Labs, Inc. All rights reserved. | ||
| // See the file LICENSE for licensing terms. | ||
|
|
||
| package simplex | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "sync" | ||
| "sync/atomic" | ||
|
|
||
| "github.com/ava-labs/simplex/common" | ||
| metadata "github.com/ava-labs/simplex/msm" | ||
| ) | ||
|
|
||
| type epochChangeSupression struct { | ||
| lock sync.RWMutex | ||
| sealingBlockSeq uint64 | ||
| active bool | ||
| } | ||
|
|
||
| func (ecs *epochChangeSupression) isSupressionActive() bool { | ||
| ecs.lock.RLock() | ||
| defer ecs.lock.RUnlock() | ||
| return ecs.active | ||
| } | ||
|
|
||
| func (ecs *epochChangeSupression) sendProhibited(seq uint64) bool { | ||
| ecs.lock.RLock() | ||
| defer ecs.lock.RUnlock() | ||
| if !ecs.active { | ||
| return false | ||
| } | ||
| return seq > ecs.sealingBlockSeq | ||
| } | ||
|
|
||
| func (ecs *epochChangeSupression) setSupression(sealingBlockSeq uint64) { | ||
| ecs.lock.Lock() | ||
| defer ecs.lock.Unlock() | ||
| ecs.sealingBlockSeq = sealingBlockSeq | ||
| ecs.active = true | ||
| } | ||
|
|
||
| func (ecs *epochChangeSupression) clearSupression() { | ||
| ecs.lock.Lock() | ||
| defer ecs.lock.Unlock() | ||
| ecs.active = false | ||
| } | ||
|
|
||
| type Communication struct { | ||
| epochChangeSupression *epochChangeSupression | ||
| nodes atomic.Value // common.Nodes | ||
| Sender | ||
| Broadcaster | ||
| } | ||
|
|
||
| func (c *Communication) SetValidators(nodes common.Nodes) { | ||
| c.nodes.Store(nodes) | ||
| } | ||
|
|
||
| func (c *Communication) Validators() common.Nodes { | ||
| nodes, ok := c.nodes.Load().(common.Nodes) | ||
| if !ok { | ||
| return nil | ||
| } | ||
| return nodes | ||
| } | ||
|
|
||
| func (c *Communication) Broadcast(msg *common.Message) { | ||
| if c.epochChangeSupression.sendProhibited(msg.Seq()) { | ||
| return | ||
| } | ||
|
|
||
| c.Broadcaster.Broadcast(msg) | ||
| } | ||
|
|
||
| func (c *Communication) Send(msg *common.Message, destination common.NodeID) { | ||
| if c.epochChangeSupression.sendProhibited(msg.Seq()) { | ||
| return | ||
| } | ||
|
|
||
| c.Sender.Send(msg, destination) | ||
| } | ||
|
|
||
| type EpochAwareStorage struct { | ||
| msm *metadata.StateMachine | ||
| OnEpochChange func(seq uint64, validators common.Nodes) error | ||
| Storage | ||
| Epoch uint64 | ||
| } | ||
|
|
||
| func (e *EpochAwareStorage) Retrieve(seq uint64) (common.VerifiedBlock, common.Finalization, error) { | ||
| block, finalization, err := e.Storage.GetBlock(seq) | ||
| if err != nil { | ||
| return nil, common.Finalization{}, err | ||
| } | ||
| parsedBlock := &ParsedBlock{ | ||
| msm: e.msm, | ||
| StateMachineBlock: block, | ||
| } | ||
| return parsedBlock, *finalization, nil | ||
| } | ||
|
|
||
| func (e *EpochAwareStorage) Index(ctx context.Context, block common.VerifiedBlock, certificate common.Finalization) error { | ||
| if block.BlockHeader().Epoch < e.Epoch { | ||
| // This is a Telock from a previous h, so we ignore it and do not index it. | ||
| return nil | ||
| } | ||
| if err := e.Storage.Index(ctx, block, certificate); err != nil { | ||
| return err | ||
| } | ||
| if block.SealingBlockInfo() != nil { | ||
| if err := e.OnEpochChange(block.BlockHeader().Seq, block.SealingBlockInfo().ValidatorSet); err != nil { | ||
| return err | ||
| } | ||
| // We are now in a new h, so we update the h number to prevent indexing Telocks from the previous h. | ||
| e.Epoch = block.BlockHeader().Seq | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| type cachedBlock struct { | ||
| cache *CachedStorage | ||
| *ParsedBlock | ||
| } | ||
|
|
||
| func (cb *cachedBlock) Verify(ctx context.Context) (common.VerifiedBlock, error) { | ||
| vb, err := cb.ParsedBlock.Verify(ctx) | ||
| if err == nil { | ||
| cb.cache.insertBlock(cb.ParsedBlock) | ||
| } | ||
| return vb, err | ||
| } | ||
|
|
||
| type CachedStorage struct { | ||
| msm *metadata.StateMachine | ||
| lock sync.RWMutex | ||
| Storage | ||
| cache map[[32]byte]cachedBlock | ||
| } | ||
|
|
||
| func NewCachedStorage(storage Storage) *CachedStorage { | ||
| return &CachedStorage{ | ||
| Storage: storage, | ||
| cache: make(map[[32]byte]cachedBlock), | ||
| } | ||
| } | ||
|
|
||
| func (cs *CachedStorage) RetrieveBlock(seq uint64, digest [32]byte) (metadata.StateMachineBlock, *common.Finalization, error) { | ||
| block, finalization, err := cs.Retrieve(seq, digest) | ||
| if err != nil { | ||
| return metadata.StateMachineBlock{}, nil, err | ||
| } | ||
|
|
||
| return block.(*ParsedBlock).StateMachineBlock, finalization, nil | ||
| } | ||
|
|
||
| func (cs *CachedStorage) Retrieve(seq uint64, digest [32]byte) (common.VerifiedBlock, *common.Finalization, error) { | ||
| cs.lock.RLock() | ||
| item, exists := cs.cache[digest] | ||
| if exists { | ||
| cs.lock.RUnlock() | ||
| // If the block is cached, it means it's not finalized yet, because upon finalizing the block (indexing) | ||
| // we also remove it from the cache. Therefore, we return nil for the finalization. | ||
| return item.ParsedBlock, nil, nil | ||
| } | ||
| cs.lock.RUnlock() | ||
|
|
||
| // We don't populate the cache here because we populate it externally. | ||
|
|
||
| block, finalization, err := cs.Storage.GetBlock(seq) | ||
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
|
|
||
| return &ParsedBlock{ | ||
| StateMachineBlock: block, | ||
| msm: cs.msm, | ||
| }, finalization, nil | ||
| } | ||
|
|
||
| func (cs *CachedStorage) Index(ctx context.Context, block common.VerifiedBlock, certificate common.Finalization) error { | ||
| err := cs.Storage.Index(ctx, block, certificate) | ||
|
|
||
| if err == nil { | ||
| // We delete the block from the cache after it has been indexed because now that it is persisted, | ||
| // we can just lookup by sequence number instead of digest. | ||
| cs.lock.Lock() | ||
| defer cs.lock.Unlock() | ||
| delete(cs.cache, block.BlockHeader().Digest) | ||
| } | ||
|
|
||
| return err | ||
| } | ||
|
|
||
| func (cs *CachedStorage) insertBlock(block *ParsedBlock) { | ||
| cs.lock.Lock() | ||
| defer cs.lock.Unlock() | ||
|
|
||
| cs.cache[block.Digest()] = cachedBlock{ | ||
| ParsedBlock: block, | ||
| } | ||
| } | ||
|
|
||
| type NoopAuxiliaryInfoApp struct{} | ||
|
|
||
| func (n *NoopAuxiliaryInfoApp) IsLegalAppend(versionID metadata.VersionID, nodes metadata.NodeBLSMappings, history [][]byte, x []byte) error { | ||
| if len(x) > 0 { | ||
| return fmt.Errorf("input should be empty") | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (n *NoopAuxiliaryInfoApp) IsSufficient(versionID metadata.VersionID, nodes metadata.NodeBLSMappings, history [][]byte) (bool, error) { | ||
| return true, nil | ||
| } | ||
|
|
||
| func (n *NoopAuxiliaryInfoApp) Generate(versionID metadata.VersionID, nodes metadata.NodeBLSMappings, history [][]byte) ([]byte, error) { | ||
| return nil, nil | ||
| } | ||
|
|
||
| func (n *NoopAuxiliaryInfoApp) DefaultVersionID() metadata.VersionID { | ||
| return 0 | ||
| } | ||
|
|
||
| type BlockBuilderWaiter struct { | ||
| epochChangeSupression *epochChangeSupression | ||
| lock sync.Mutex | ||
| cancel context.CancelFunc | ||
| msm *metadata.StateMachine | ||
| vm VM | ||
| } | ||
|
|
||
| func (bw *BlockBuilderWaiter) stop() { | ||
| bw.lock.Lock() | ||
| defer bw.lock.Unlock() | ||
| if bw.cancel != nil { | ||
| bw.cancel() | ||
| bw.cancel = nil | ||
| } | ||
| } | ||
|
|
||
| func (bw *BlockBuilderWaiter) WaitForPendingBlock(ctx context.Context) { | ||
| if bw.epochChangeSupression.isSupressionActive() { | ||
| <- ctx.Done() // We wait for the context to be cancelled once the epoch is tore down. | ||
| return | ||
| } | ||
|
|
||
| bw.lock.Lock() | ||
| if bw.cancel != nil { | ||
| bw.cancel() | ||
| } | ||
| ctx, cancel := context.WithCancel(ctx) | ||
| bw.cancel = cancel | ||
| bw.lock.Unlock() | ||
| defer cancel() | ||
| bw.vm.WaitForPendingBlock(ctx) | ||
| } | ||
|
|
||
| func (bw *BlockBuilderWaiter) BuildBlock(ctx context.Context, metadata common.ProtocolMetadata, blacklist common.Blacklist) (common.VerifiedBlock, bool) { | ||
| if bw.epochChangeSupression.isSupressionActive() { | ||
| return nil, false | ||
| } | ||
|
|
||
| block, err := bw.msm.BuildBlock(ctx, metadata, &blacklist) | ||
| if err != nil { | ||
| return nil, false | ||
| } | ||
|
|
||
| pb := ParsedBlock{ | ||
| StateMachineBlock: *block, | ||
| msm: bw.msm, | ||
| } | ||
|
|
||
| return &pb, true | ||
| } | ||
|
|
||
| type blockDeserializer struct { | ||
| vm VM | ||
| msm *metadata.StateMachine | ||
| } | ||
|
|
||
| func (bp *blockDeserializer) DeserializeBlock(ctx context.Context, bytes []byte) (common.Block, error) { | ||
| var rawBlock RawBlock | ||
| if err := rawBlock.UnmarshalCanoto(bytes); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| block, err := bp.vm.ParseBlock(ctx, rawBlock.InnerBlockBytes) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &ParsedBlock{ | ||
| StateMachineBlock: metadata.StateMachineBlock{ | ||
| InnerBlock: block, | ||
| Metadata: rawBlock.Metadata, | ||
| }, | ||
| msm: bp.msm, | ||
| }, nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does this mean the block is a telock? don't telocks have the same epoch as the sealing block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a Telock from the previous epoch. We may collect a finalization on a Telock and then we first index the sealing block and then the Telocks. Once we index the sealing block, we increment our epoch, right?
We don't want to index the Telocks too, so this is a safeguard against that.