Conversation
| if e.s3_output_bucket.is_empty() { | ||
| resp = results_vec; | ||
| }else { | ||
| // No extra configuration is needed as long as your Lambda has |
There was a problem hiding this comment.
If there are prerequisite permissions to be granted to Lambda role, let's add a documentation in README for Lambda for granting required permissions to the access policy such as bucket s3:PutObject action.
|
This item is currently being reviewed. As the AWS SDK is in Developer Preview, this will not be merged to main. Will follow up soon. |
satyakigh
left a comment
satyakigh
left a comment
There was a problem hiding this comment.
This branch needs to be rebased and reimplemented against the current Lambda API before the S3 behavior can be reviewed safely. It currently conflicts with main and uses the old lambda_runtime handler_fn/Context two-argument handler and old run_checks call; current main uses service_fn/LambdaEvent, ValidateInput, and tests that call the public one-argument handler. The PR also adds no tests for the S3 branch. Please update the implementation to current main, preserve the existing event/handler contract, and add success/error tests for the upload path.
4 participants
Issue #, if available: #236
Description of changes:
Added new flag to guard-lambda to send output to S3 bucket
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license