Add Cantina audit report for the rounding and billing change (v1.1.0, #90) - #93
Merged
Conversation
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
Collaborator
✅ Heimdall Review Status
|
Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
amiecorso
reviewed
Jul 25, 2026
| | Spearbit audit 1 | 04/01/2025 | [Report](/audits/Cantina-Report-04-01-2025.pdf) | | ||
| | Coinbase Protocol Security audit 3 | 04/15/2025 | [Report](/audits/CommercePaymentsAudit3CoinbaseProtoSec.pdf) | | ||
| | Spearbit audit 2 | 04/22/2025 | [Report](/audits/Cantina-Report-04-22-2025.pdf) | | ||
| | Spearbit audit 3 (rounding and billing fix, #90) | 07/22/2026 | [Report](/audits/report-cli-cantina-eb1cc8bc-577c-422d-ad76-db7495f29a5a-2026-07-22-coinbase-commerce-payments-pr-90.pdf) | |
Collaborator
There was a problem hiding this comment.
only feedback is maybe let's call this "rounding and billing change, v1.1.0" because "fix" implies something was broken when really it was just that we had need for a different product requirement around rounding
… review 'Fix' implied something was broken; it was a product-requirement change to rounding/billing. Adopts @amiecorso's suggested wording. Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
RuoHan-Chen
changed the title
Collaborator
Author
|
Good call — updated to "rounding and billing change, v1.1.0" in the title, PR body, and both audit tables (README + docs/Security.md). Agreed that "fix" mischaracterized it; it was a product-requirement change to rounding/billing, not a bug fix. Thanks @amiecorso. |
amiecorso
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Cantina audit report covering the rounding and billing change from #90 (the fixed-fee
feeAmountproduct-requirement change shipped in v1.1.0), and lists it in the security audit tables alongside the existing reports.audits/report-cli-cantina-eb1cc8bc-577c-422d-ad76-db7495f29a5a-2026-07-22-coinbase-commerce-payments-pr-90.pdfChanges
audits/README.mddocs/Security.mdThis completes the audit provenance for the v1.1.0 rounding and billing change: the prior committed reports predate #90, and this report is the review of that specific change.