fix: quote variables to prevent word-splitting (SC2086)#1097
Open
okwn wants to merge 4 commits into
Open
Conversation
…mpose Addresses issues base#1054 and base#1045 - if either the consensus client or execution client crashes, supervisord will now automatically restart it without requiring manual operator intervention. Also adds a healthcheck to the execution service so docker compose ps accurately reflects service health rather than always showing healthy.
The consensus service (port 7545) is mapped in docker-compose.yml, but .env.mainnet and .env.sepolia did not define BASE_NODE_RPC_PORT, so the consensus RPC was unreachable from the host on the expected mapped port. Fixes issue base#1088.
Quotes unquoted variables in execution-entrypoint to comply with ShellCheck SC2086 (double quoting to prevent word splitting). Fixes: - $ADDITIONAL_ARGS when appending pruning args - $RETH_FB_WEBSOCKET_URL in the Flashblocks conditional
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SC2086 ShellCheck warnings in execution-entrypoint by properly quoting variables to prevent word splitting.
Changes
$ADDITIONAL_ARGS→"${ADDITIONAL_ARGS}""when appending pruning args$RETH_FB_WEBSOCKET_URL→"${RETH_FB_WEBSOCKET_URL}""in Flashblocks conditionalThese changes prevent potential word-splitting issues if variables contain whitespace.