Fail shell and CLI tests when ripgrep is missing - #7405
Open
686f6c61 wants to merge 1 commit into
Open
Conversation
Negative rg guards treat a missing binary as no match, so several files print ok instead of failing. Require rg up front in test/shell.d/base-test.sh and test/cli.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7122
Several shell tests (and two
test/cliguards) usergin negative form. A missing binary is exit 127,if rgtreats that as "no match", and the file printsok.require_commandalready exists forjq/python3/node; nothing asked forrg.Require it when
test/shell.d/base-test.shis sourced and at the start oftest/cli. Ripgrep is in Omarchy's default package set; this only bites a stripped PATH or a broken install.Verified: