Capture open plugin panels in screenshots - #7415
Open
ArthurWillers wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds “capture target” geometry for visible plugin panel content so the screenshot/recording picker can snap to what the user actually sees (not full-screen transparent layer-shell surfaces).
Changes:
- Introduces a
CaptureTargetQML helper and shell APIs to register/collect visible panel “card” geometry (listCaptureTargets). - Updates multiple plugins/panels to register their visible card as a capture target.
- Extends
omarchy-capture-regionto include open-plugin rects and to consider all monitors; adds a shell test and updates docs/bindings wording to “target”.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/shell.d/capture-region-test.sh | Adds an integration-style shell test validating candidate geometries include open plugin panel rects. |
| shell/shell.qml | Adds capture target registry + exposes listCaptureTargets for external tools. |
| shell/plugins/reminders/ReminderFlow.qml | Registers reminders panel card as a capture target. |
| shell/plugins/panels/wifiqr/Panel.qml | Adds ids and registers wifiqr panel card as a capture target. |
| shell/plugins/osd/Osd.qml | Adds shell property and registers OSD card as a capture target. |
| shell/plugins/menu/Menu.qml | Registers menu panel card as a capture target. |
| shell/plugins/image-picker/ImagePicker.qml | Adds shell property/import and registers image picker card as a capture target. |
| shell/plugins/emojis/Emojis.qml | Registers emojis panel card as a capture target. |
| shell/plugins/clipboard/Clipboard.qml | Adds shell property and registers clipboard panel card as a capture target. |
| shell/Ui/qmldir | Exposes CaptureTarget as a QML type in qs.Ui. |
| shell/Ui/KeyboardPanel.qml | Registers keyboard panel card as a capture target (with derived targetId). |
| shell/Ui/CaptureTarget.qml | New helper object computing card geometry and registering with the shell. |
| manual/12-screenshots-recording.md | Updates docs to mention snapping to open plugin panels and “targets” terminology. |
| default/hypr/bindings/utilities.lua | Renames selection binding descriptions from “window” to “capture target”. |
| bin/omarchy-capture-region | Adds open-plugin rect collection via omarchy-shell, broadens monitor rects, and integrates new target rects into selection logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated no new comments.
Suppressed comments (1)
shell/shell.qml:435
CaptureTarget.qmldefines the identifier astargetId, but this log line readstarget.targetId, which will always be undefined and degrade diagnostics. Usetarget.targetIdonly if the property is actually named that way; otherwise switch this totarget.targetId→target.targetId’s correct property name (target.targetIdshould betarget.targetId->target.targetIdis currently wrong; should betarget.targetId->target.targetIdistarget.targetId?); concretely, update it to referencetarget.targetId→target.targetId’s actual property (target.targetIdshould betarget.targetId?). (Mandatory: fix so warnings include the target id.)
try { geometry = target.captureGeometry() } catch (e) {
console.warn("capture geometry failed for", target.targetId || "unknown target", e)
return
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots can select the visible card of an open plugins.
Verification
🤖 Implemented and validated with OpenAI Codex in collaboration with @ArthurWillers.