enable openvpn-client on remaining hosts (batch 3, 7 nodes) - #39
Merged
Conversation
- online (nuke, co2wz, rasp3): laptop PKI md5-identical to live; nuke fully converged already, co2wz/rasp3 only need the persistent enable symlink - offline (fire, hell, sun, nuke-workspace): laptop PKI complete; bundle applies whenever the hosts are next online
![ben-s-pull-request-reviewer[bot]](https://avatars.githubusercontent.com/u/1193284?s=60&v=4){kind=small}
There was a problem hiding this comment.
{
"verdict": "approve",
"summary": "PR enables openvpn-client on 7 remaining hosts (batch 3) following the established pattern from batches 1 and 2. All 7 files show consistent naming: the 'name' field matches the hostname prefix and dictionary key for each node. No security concerns — hostname values are static and not user-controlled. Pattern matches the prior openvpn-client adoptions already in master.",
"comments": [],
"concerns_addressed": [
"security: openvpn-client enabled with hostnames derived from static hostname field, not user-controlled — confirmed",
"correctness: name field matches actual hostname prefix across all 7 files (co2wz, fire, hell, nuke-workspace, nuke, rasp3, sun) — confirmed"
]
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final rollout batch (#37 bundle+canary, #38 k3s fleet — both applied clean, all tunnels uninterrupted).
Nodes
bw verify: nuke fully converged (0 changes); co2wz/rasp3 onlysystemctl enable openvpn@client(no restart).After this lands + applies, every world-managed VPN client is bw-owned → next PR removes openvpn from world entirely.