Zero token must not attach a fenced volume - #91
Merged
Conversation
fence_attach(9,4,0,0) is Grant today; attach_fence on the same tokens is Reject. First attach against (0,0) stays Grant. This fails on current main.
fence_attach now is attach_fence on the composed tokens. First attach (stored 0,0) still Grants. A zero token against a fenced volume Rejects.
API suite still expected the gen-0 bypass (201). Same machine as fence_attach: (0,0) against stored gen 9 is Reject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fence_attach(9, 4, 0, 0)Granted.attach_fenceon the same composed tokens Rejects. The recovery model checks the pure rule; storage ran the wrapper. Combined with create stampingplacement_generation = 0, the first attach is the bypass.Two commits: a test that fails on main, then
fence_attachis justattach_fenceon the composed tokens. First attach against(0,0)still Grants (>=). A(0,0)caller against a volume that already holds a token Rejects.git checkout HEAD~1 && cargo test --lib zero_tokenfails; HEAD passes.