Replay of an inline overwrite must clear the VALUE_SEP sidecar - #12
Open
paulocsanz wants to merge 2 commits into
Open
Replay of an inline overwrite must clear the VALUE_SEP sidecar#12paulocsanz wants to merge 2 commits into
paulocsanz wants to merge 2 commits into
Conversation
apply_record only writes the valsep sidecar on VALUE_SEP, so an inline overwrite leaves the hash. Reopen then sweep_orphans keeps the blob. This fails on current main.
Match the live write path: a full inline record sets valsep to None so crash replay + sweep_orphans does not resurrect the previous VALUE_SEP blob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply_recordonly wrote the valsep sidecar onVALUE_SEP. A later inline put (live path:set_valsep(None)) left the hash in place. Crash-reopen of the unsealed active file thenincr_ref+sweep_orphanskept the large blob, and the next seal wrote the stale hash into the footer. GET stayed correct. Two commits: a test that fails on main, then the fix.set_valsep(None), matchingapply_valsep_insert.git checkout HEAD~1 && cargo test -p beyond-kv-engine --lib crash_after_large_then_smallfails; HEAD passes.