Sealed watch catch-up must not drop the tail on mid-file CRC - #14
Open
paulocsanz wants to merge 2 commits into
Open
Sealed watch catch-up must not drop the tail on mid-file CRC#14paulocsanz wants to merge 2 commits into
paulocsanz wants to merge 2 commits into
Conversation
scan_since returned Ok([keep]) after flipping the middle sealed record. rebuild_from_records already fail-stops on the same bytes.
scan_since treated a sealed CRC miss like a torn active tail and returned Ok(prefix). Later keys never reached the subscriber and there was no resync. Active files still stop — that is a torn write.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebuild_from_recordsalready fail-stops on a sealed mid-file CRC (#11).scan_since(watch reconnect) on the same bytes returnedOk([keep])and dropped every later key. The subscriber thinks catch-up finished.Two commits: failing production test, then fail-stop on sealed files only. The active file still stops at a torn write (
watch_replay_skips_crc_corrupted_recordstays green).scan_file_recordstakessealedCrcMismatch