Corrupt footer CRC must rebuild, not refuse the namespace - #17
Open
paulocsanz wants to merge 2 commits into
Open
Corrupt footer CRC must rebuild, not refuse the namespace#17paulocsanz wants to merge 2 commits into
paulocsanz wants to merge 2 commits into
Conversation
ARCHITECTURE.md says a corrupt sealed footer falls back to a record scan. read_footer().await? currently fails the open.
ARCHITECTURE.md says a corrupt sealed footer falls back to a record scan. read_footer().await? failed the whole namespace. Missing magic is still a torn active file; CRC/BadRecord is bitrot of a completed trailer — rebuild and rotate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open_namespacecomments and ARCHITECTURE.md say a corrupt sealed footer falls back to a sequential record scan.read_footer().await?treated CRC/range errors as fatal, so a one-bit flip in the trailer CRC (magic intact) refused the whole namespace. Their crash test only truncates the trailer (magic gone →None).Two commits: failing production test, then classify footer as Ok / Missing / Corrupt. Missing still means torn active. Corrupt rebuilds and rotates.
rebuild_from_records