Footer body and trailer must be one append - #18
Open
paulocsanz wants to merge 2 commits into
Open
Conversation
write_footer is two appends. A put landing between them makes read_footer CRC-fail (rotate has no freeze).
Two SQEs let a sibling put split the trailer. rotate does not freeze writers. One append makes the trailer contiguous.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_footerdidappend(body)thenappend(trailer).rotate_activedoes notfreeze_and_drain(seal does). A put on another stripe between the two SQEs yields[records][footer_body][PUT][trailer].read_footersees magic at EOF, uses the originalbody_len, CRC-fails, and open refuses the namespace.Two commits: inject-between-appends test (CRC fail on main), then one append of
body || trailer.