Leaked pre-delete sealed file must not resurrect keys - #19
Open
paulocsanz wants to merge 2 commits into
Open
Conversation
apply_footer_entries is insert-only. An unlinked pre-delete file that reappears on disk puts the tombstoned key back in the index.
apply_footer is insert-only. If unlink of an input fails (or a crash leaves the file), reopen applies the old footer and resurrects deletes. Write data-N.log.replaces before unlink; open ignores those ids even if the log reappears.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reclaim unlinks old sealed files best-effort and returns Ok on leak.
apply_footer_entriesonly inserts. Adata-0.logthat comes back after a compact (crash between rename and unlink, orremove_fileErr) puts tombstoned keys back in the index.Two commits: failing leak-and-reopen test, then a durable
data-N.log.replacessidecar written before unlink. Open skips those file ids. Sidecars union parent replaces so a later compact still hides the original inputs.