Skip to content

fix(returns): ORDERS-7752 rename keys to be snake_case for consistency - #2711

Merged
bc-bryan merged 3 commits into
feature/PROJECT-7525-new-returns-flowfrom
ORDERS-7752-rename-returns-keys-to-snake-case
Jul 28, 2026
Merged

fix(returns): ORDERS-7752 rename keys to be snake_case for consistency#2711
bc-bryan merged 3 commits into
feature/PROJECT-7525-new-returns-flowfrom
ORDERS-7752-rename-returns-keys-to-snake-case

Conversation

@bc-bryan

@bc-bryan bc-bryan commented Jul 22, 2026

Copy link
Copy Markdown

What?

Changes the keys to match the stencil context returned front the storefront api.

Tickets / Documentation

Add links to any relevant tickets and documentation.


Note

Low Risk
Template-only property renames with no logic changes; low risk unless the API context still exposes camelCase keys, which would break resolution display.

Overview
Updates return details item resolution fields in return-details.html so Handlebars reads snake_case keys from the storefront return_detail.items context instead of camelCase.

Renamed bindings include requested_differs_from_resolved, requested_resolution_type, requested_resolution_name, resolved_resolution_type, and resolved_resolution_name. Display logic (strikethrough when request differs from resolved, custom vs translated resolution labels) is unchanged.

Reviewed by Cursor Bugbot for commit 60f0e5a. Bugbot is set up for automated code reviews on this repo. Configure here.

@bc-bryan
bc-bryan requested a review from a team as a code owner July 22, 2026 01:58
@BC-SEven
BC-SEven force-pushed the feature/PROJECT-7525-new-returns-flow branch from de1a079 to 4f7dccc Compare July 27, 2026 01:17
@bc-vivekaggarwal

Copy link
Copy Markdown

Sorry I missed email alert for this PR. Could you please post PR review requests in project-returns from next time?
@bc-bryan Can you please rebase your branch onto feature branch? I'll take a look.
image

jpajar and others added 3 commits July 28, 2026 09:43
@bc-bryan
bc-bryan force-pushed the ORDERS-7752-rename-returns-keys-to-snake-case branch from fa1fb24 to 60f0e5a Compare July 27, 2026 23:47

@bc-vivekaggarwal bc-vivekaggarwal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bc-bryan Appreciate fixing this on FE too.
Happy to merge this without waiting for Trac team. This is a simple and safe change

@bc-bryan
bc-bryan merged commit 857086f into feature/PROJECT-7525-new-returns-flow Jul 28, 2026
1 check passed
@bc-bryan
bc-bryan deleted the ORDERS-7752-rename-returns-keys-to-snake-case branch July 28, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants