Skip to content

BIP-352: clarify silent payment address length - #2271

Open
notTanveer wants to merge 1 commit into
bitcoin:masterfrom
notTanveer:fix/sp-addr-len
Open

BIP-352: clarify silent payment address length#2271
notTanveer wants to merge 1 commit into
bitcoin:masterfrom
notTanveer:fix/sp-addr-len

Conversation

@notTanveer

Copy link
Copy Markdown

the address length note only gave 117 chars as the number to check against, using a 3-char HRP as the example without saying mainnet uses "sp" (2 chars, 116 total).

@nymius nymius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with mainnet test vectors for sp codes.

ACK 66c0c6d

Comment thread bip-0352.mediawiki Outdated
*** The 66-byte concatenation of the receiver's public keys, ''ser<sub>P</sub>(B<sub>scan</sub>) || ser<sub>P</sub>(B<sub>m</sub>)''

Note: [https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki BIP173] imposes a 90 character limit for Bech32 segwit addresses and limits versions to 0 through 16, whereas a silent payment address requires ''at least'' 117 characters<ref name="why_117_chars"> ''' Why do silent payment addresses need at least 117 characters?''' A silent payment address is a bech32m encoding comprised of the following parts:
Note: [https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki BIP173] imposes a 90 character limit for Bech32 segwit addresses and limits versions to 0 through 16, whereas a silent payment address requires ''at least'' 116 characters for mainnet (117 characters for testnets, since the "tsp" HRP is 3 characters)<ref name="why_117_chars"> ''' Why do silent payment addresses need at least 116 (117 for testnets) characters?''' A silent payment address is a bech32m encoding comprised of the following parts:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the ref name can be changed too: why_116_chars

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants