Modernize code style with C# 12 syntax - #509
Closed
kingsznhone wants to merge 2 commits into
Closed
Conversation
Contributor
|
To maintain backwards compatibility with .NET standard 2.1 it has to remain the same. Software like Unity use c# 9.0 and the performance gains are minimal. I appreciate the effort to modernize the sdk 🦾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repo contains legacy coding styles left over from many years ago.
Solution
Modernized the transaction decoding example using C# 12 syntax and improved code formatting. Replaced the traditional signature array initialization with a collection expression, improved the readability of large numeric literals, and reformatted fluent transaction-builder calls and long output statements. The transaction construction, signing, serialization, decoding, and simulation behavior remain unchanged.