Skip to content

Modernize code style with C# 12 syntax - #509

Closed
kingsznhone wants to merge 2 commits into
bmresearch:masterfrom
kingsznhone:master
Closed

Modernize code style with C# 12 syntax#509
kingsznhone wants to merge 2 commits into
bmresearch:masterfrom
kingsznhone:master

Conversation

@kingsznhone

Copy link
Copy Markdown
Contributor

⚠️ NOTE: Use notes like this to emphasize something important about the PR.

This could include other PRs this PR is built on top of; API breaking changes; reasons for why the PR is on hold; or anything else you would like to draw attention to.

Status Type ⚠️ Core Change Issue
Ready Refactor No

Problem

The repo contains legacy coding styles left over from many years ago.

Solution

Modernized the transaction decoding example using C# 12 syntax and improved code formatting. Replaced the traditional signature array initialization with a collection expression, improved the readability of large numeric literals, and reformatted fluent transaction-builder calls and long output statements. The transaction construction, signing, serialization, decoding, and simulation behavior remain unchanged.

@BifrostTitan

Copy link
Copy Markdown
Contributor

To maintain backwards compatibility with .NET standard 2.1 it has to remain the same. Software like Unity use c# 9.0 and the performance gains are minimal.

I appreciate the effort to modernize the sdk 🦾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants