submission: stop logging secret names at INFO#169
Open
KartikP wants to merge 1 commit into
Open
Conversation
The secret name (not value) was being logged from multiple endpoints and from get_secret(). Demote to DEBUG so it stays available locally without leaking the deployment topology to anyone with build-log access.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container scoring logs were printing the AWS secret name on every db connect (3 call sites in endpoints.py + 3 lines in utils.get_secret). The name isn't the value, but exposing it leaks deployment topology (prod vs staging) to anyone with build-log access. Demote to DEBUG everywhere.