docs: Replace PLACEHOLDER with local dive output image#945
Open
lcampanella98 wants to merge 1 commit into
Open
docs: Replace PLACEHOLDER with local dive output image#945lcampanella98 wants to merge 1 commit into
lcampanella98 wants to merge 1 commit into
Conversation
Reference the dive screenshot from static/images instead of imgur so the image can't disappear if the imgur upload is pruned. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Fixes #785
Problem
The "Inspect your app" how-to page had a literal
PLACEHOLDERwhere a screenshot of thedive multi-process-appoutput should be. Readers saw the word "PLACEHOLDER" instead of the image the surrounding text describes.Solution
I replaced the placeholder with the
diveoutput screenshot. Instead of hotlinking the image from imgur (the existing precedent in this repo), I committed the PNG into the theme's static assets and reference it locally:themes/buildpacks/static/images/dive-inspect-app.png./images/dive-inspect-app.png, matching how every other diagram in the docs is linked.This avoids a runtime dependency on imgur, which can prune images that go unviewed for a while. I also gave the image alt text, which the imgur references elsewhere lack.
Testing
dive multi-process-appscreenshot (shows Layers, Layer Details, Image Details, and Current Layer Contents).Additional Info