Skip to content

Fix nav.html include path in index.html#537

Open
stupidloud wants to merge 1 commit into
caddyserver:masterfrom
stupidloud:patch-1
Open

Fix nav.html include path in index.html#537
stupidloud wants to merge 1 commit into
caddyserver:masterfrom
stupidloud:patch-1

Conversation

@stupidloud

@stupidloud stupidloud commented May 4, 2026

Copy link
Copy Markdown

Fix a broken include path in src/docs/json/index.html by changing {{include "/includes/docs/nav.html"}} to {{include "/old/includes/docs/nav.html"}}, so the JSON docs page loads the correct nav partial.

@mholt

mholt commented Jun 2, 2026

Copy link
Copy Markdown
Member

What? Why? What is broken?

@stupidloud

Copy link
Copy Markdown
Author

Hi @mholt, sorry for the terse PR description — let me explain what I ran into.

On the current master, visiting /docs/json/ fails to render the docs nav because src/docs/json/index.html includes /includes/docs/nav.html, but that file doesn't exist in the repo. src/includes/docs/ only contains details.html, hovercard.html, and renderbox.html. The actual nav.html lives at src/old/includes/docs/nav.html.

The sibling page src/docs/modules/index.html already includes the nav from /old/includes/docs/nav.html, so this PR just brings json/index.html in line with it. Happy to take a different approach if you'd prefer the file moved/symlinked instead — just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants