Skip to content

refactor(types): deepen type consolidation#743

Merged
thymikee merged 2 commits into
mainfrom
refactor/deepen-type-consolidation
Jun 10, 2026
Merged

refactor(types): deepen type consolidation#743
thymikee merged 2 commits into
mainfrom
refactor/deepen-type-consolidation

Conversation

@thymikee

Copy link
Copy Markdown
Member

Summary

Deepens the follow-up refactor from the type/contract audit in one PR:

  • makes runtime enum tuples canonical for contracts, device selectors, finder locators, wait kinds, and network include modes
  • brands normalized screenshot rects/points so percent-space geometry cannot be mixed with pixel geometry by accident
  • shares result envelopes, daemon invoker signatures, env-map aliases, and string-enum parsing helpers across modules

Touched-file count: 50. Scope intentionally spans command metadata/contracts, screenshot diff geometry, daemon/Maestro invocation types, and env/config helpers to cover the requested follow-ups together.

Validation

Passed: pnpm format, pnpm check:quick, and focused unit coverage for screenshot/output paths with pnpm exec vitest run --project unit src/utils/__tests__/screenshot-diff-ocr.test.ts src/utils/__tests__/screenshot-diff-non-text.test.ts src/utils/__tests__/output.test.ts.

Attempted: pnpm check:unit. The first sandboxed run failed on local listener restrictions (listen EPERM). The unsandboxed rerun reduced this to 7 Android mocked-tool timeout failures in existing Android device/install tests, outside this refactor's touched areas.

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.2 MB 1.2 MB +795 B
JS gzip 385.4 kB 386.1 kB +695 B
npm tarball 496.7 kB 497.7 kB +1.1 kB
npm unpacked 1.7 MB 1.7 MB +3.0 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 25.7 ms 25.9 ms +0.2 ms
CLI --help 41.1 ms 40.9 ms -0.1 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/8699.js -59 B +43 B
dist/src/cli.js -35 B +42 B
dist/src/command-metadata.js +12 B +28 B
dist/src/2353.js +32 B +17 B
dist/src/2415.js +1 B +14 B

@thymikee thymikee merged commit b30292d into main Jun 10, 2026
20 checks passed
@thymikee thymikee deleted the refactor/deepen-type-consolidation branch June 10, 2026 12:05
@github-actions

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-10 12:05 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant