refactor(types): deepen type consolidation#743
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deepens the follow-up refactor from the type/contract audit in one PR:
Touched-file count: 50. Scope intentionally spans command metadata/contracts, screenshot diff geometry, daemon/Maestro invocation types, and env/config helpers to cover the requested follow-ups together.
Validation
Passed:
pnpm format,pnpm check:quick, and focused unit coverage for screenshot/output paths withpnpm exec vitest run --project unit src/utils/__tests__/screenshot-diff-ocr.test.ts src/utils/__tests__/screenshot-diff-non-text.test.ts src/utils/__tests__/output.test.ts.Attempted:
pnpm check:unit. The first sandboxed run failed on local listener restrictions (listen EPERM). The unsandboxed rerun reduced this to 7 Android mocked-tool timeout failures in existing Android device/install tests, outside this refactor's touched areas.