refactor: extract daemon artifact client#744
Merged
Merged
Conversation
thymikee
force-pushed
the
codex/move-daemon-contracts
branch
3 times, most recently
from
dfedaab to
8f00def
Compare
Member
Author
|
Review status: this is currently blocked before final code review because GitHub reports the PR as The artifact extraction itself looks directionally mechanical from the sampled diff, but I would not merge or deeply review it until the stack reflects the current #741 shape. |
thymikee
force-pushed
the
codex/extract-daemon-artifacts
branch
from
d43395a to
9c0a753
Compare
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
thymikee
force-pushed
the
codex/move-daemon-contracts
branch
from
8f00def to
b284e71
Compare
thymikee
force-pushed
the
codex/extract-daemon-artifacts
branch
from
9c0a753 to
d40e945
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts the first #727 daemon-client seam into
src/daemon-artifacts.ts: remote artifact upload preparation, artifact output materialization, and remote artifact download now live outsidesrc/daemon-client.tswhiledaemon-client.tsremains the public facade and re-exportsdownloadRemoteArtifact.The PR now targets
mainafter #741 merged. The change touches 3 files and keeps the scope to the artifact seam. No docs or skills were updated because this is an internal refactor with no user-facing CLI/workflow change.Refs #727
Validation
Focused artifact/client coverage passed with
pnpm exec vitest run src/utils/__tests__/daemon-client.test.ts src/__tests__/upload-client.test.ts(42 tests). Broader gates passed withpnpm check:quick,pnpm check:fallow --base origin/main,pnpm format, andgit diff --check.