You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
MCP command tool text now defaults to the same optimized, agent-friendly renderer used by CLI output projections, so snapshots and other commands with shared renderers no longer fall back to pretty JSON in content.
Added mcpOutputFormat: "optimized" | "json" as an MCP-only schema field for clients that need JSON text; it is stripped before command execution, while structuredContent remains the raw command result. Closes#747.
Touched files: 2.
Validation
Focused MCP tests pass for default optimized snapshot output, explicit JSON text output, schema exposure, and router tool listing. Full quick validation passed with lint and typecheck, and git diff --check passed.
Review status: behavior looks aligned with #747 from the diff. MCP text now defaults through the existing optimized CLI renderer, explicit mcpOutputFormat: "json" keeps JSON text available, structuredContent remains the raw result, and the MCP-only field is stripped before command execution.
The blocker is CI/maintainability: Fallow fails on src/mcp/command-tools.ts:95 readMcpToolConfig after the added branching. Please split the MCP config parsing enough to get the changed-file Fallow audit green, ideally by keeping readMcpToolConfig as orchestration and moving output-format/client-field validation into focused helpers.
Update after the latest checks: Fallow is now green on the current head. Treat my previous note as resolved/stale; I do not have a remaining code-review blocker from the sampled diff. Current status from my side is merge-ready once the remaining pending smoke/Swift CodeQL checks complete green.
Preview removed because the pull request was closed.
2026-06-10 12:28 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thymikee
force-pushed
the
fix/mcp-optimized-output
branch
from
Summary
MCP command tool text now defaults to the same optimized, agent-friendly renderer used by CLI output projections, so snapshots and other commands with shared renderers no longer fall back to pretty JSON in
content.Added
mcpOutputFormat: "optimized" | "json"as an MCP-only schema field for clients that need JSON text; it is stripped before command execution, whilestructuredContentremains the raw command result. Closes #747.Touched files: 2.
Validation
Focused MCP tests pass for default optimized snapshot output, explicit JSON text output, schema exposure, and router tool listing. Full quick validation passed with lint and typecheck, and
git diff --checkpassed.Commands run:
pnpm exec vitest run src/mcp/__tests__/command-tools.test.ts src/mcp/__tests__/router.test.ts;pnpm check:quick;pnpm format;git diff --check.