fix(MD3): update color schema and tokens #4900
Open
adrcotfas wants to merge 2 commits into@adrcotfas/feat/remove_custom_ripple_colorfrom
Open
fix(MD3): update color schema and tokens #4900adrcotfas wants to merge 2 commits into@adrcotfas/feat/remove_custom_ripple_colorfrom
adrcotfas wants to merge 2 commits into@adrcotfas/feat/remove_custom_ripple_colorfrom
Conversation
|
The mobile version of example app from this branch is ready! You can see it here. |
This was referenced Apr 15, 2026
thymikee
approved these changes
Apr 21, 2026
Comment on lines
39
to
+79
| @@ -58,6 +65,18 @@ export type MD3Colors = { | |||
| inverseSurface: string; | |||
| inverseOnSurface: string; | |||
| inversePrimary: string; | |||
| primaryFixed: string; | |||
| primaryFixedDim: string; | |||
| onPrimaryFixed: string; | |||
| onPrimaryFixedVariant: string; | |||
| secondaryFixed: string; | |||
| secondaryFixedDim: string; | |||
| onSecondaryFixed: string; | |||
| onSecondaryFixedVariant: string; | |||
| tertiaryFixed: string; | |||
| tertiaryFixedDim: string; | |||
| onTertiaryFixed: string; | |||
| onTertiaryFixedVariant: string; | |||
Collaborator
There was a problem hiding this comment.
The 19 new properties are required. Any consumer who built a custom MD3Colors literal pre-upgrade will now fail TS. Is this intended?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR updates the color schema and tokens for the MD3 themes. See:
Order of merging:
Test plan
Run the example app and observe the slightly different colors used for components, according to the latest MD3 specs.