Add JSON IO for inp::StandaloneInput#2425
Merged
amandalund merged 7 commits intoJun 17, 2026
Merged
Conversation
Test summary 5 701 files 9 289 suites 19m 3s ⏱️ Results for commit dedf71c. ♻️ This comment has been updated with latest results. |
sethrj
approved these changes
Jun 16, 2026
sethrj
left a comment
Member
There was a problem hiding this comment.
Looks good @amandalund ! I think the documentation may need updating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to add some more documentation for running our standalone apps (in particular creating inputs). Rather than do this for the
RunnerInputwhich we plan to deprecate, I'm going to go ahead and add support for usinginp::StandaloneInputwith celer-sim (celer-optical already usesinp::OpticalStandaloneInput). This first step adds the remaining json serialization needed.