Fix some compilation issues - #105
Merged
Merged
Conversation
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
This PR targets correctness issues in HOMCC’s compilation argument handling and path/output behavior, and publishes the change as a new Debian package revision.
Changes:
- Fixes behavior around
-includebeing ignored. - Adjusts handling of absolute include paths (remapping).
- Fixes output-flag handling so output-related compiler flags are respected.
- Bumps Debian package version/changelog to
1.0.4describing the above fixes.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| debian/changelog | Adds a 1.0.4 changelog entry documenting the compilation fixes. |
| .gitignore | Content excluded from this review by policy. |
| homcc/server/server.py | Content excluded from this review by policy (core server behavior). |
| homcc/server/init.py | Content excluded from this review by policy. |
| homcc/client/init.py | Content excluded from this review by policy. |
| homcc/common/arguments.py | Content excluded from this review by policy (core argument parsing/normalization). |
| homcc/server/environment.py | Content excluded from this review by policy (sandbox/environment behavior). |
| tests/server/environment_test.py | Content excluded from this review by policy (relevant test coverage). |
Files excluded by content exclusion policy (7)
- .gitignore
- homcc/client/init.py
- homcc/common/arguments.py
- homcc/server/init.py
- homcc/server/environment.py
- homcc/server/server.py
- tests/server/environment_test.py
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Oliver Layer (OliLay)
requested review from
Simon Pirsch (spirsch) and
Willi Mann (wmann-celonis)
August 17, 2026 15:38
Simon Pirsch (spirsch)
approved these changes
Aug 18, 2026
Comment on lines
+498
to
+500
| if arg not in self.INCLUDE_PREFIX_EXCLUDED_ARGS: | ||
| for path_arg in path_option_prefix_args: | ||
| if arg.startswith(path_arg): |
Collaborator
There was a problem hiding this comment.
Personal preference to keep indentation level lower:
Suggested change
| if arg not in self.INCLUDE_PREFIX_EXCLUDED_ARGS: | |
| for path_arg in path_option_prefix_args: | |
| if arg.startswith(path_arg): | |
| for path_arg in path_option_prefix_args: | |
| if arg.startswith(path_arg) and arg not in self.INCLUDE_PREFIX_EXCLUDED_ARGS: |
Feel free to ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-include,