Update to Node 24 - #28
Open
carlansley wants to merge 3 commits into
Open
Conversation
carlansley
had a problem deploying
to
npm-publish
August 27, 2026 19:30 — with 
GitHub Actions
Failure
GitHub Actions
Failure
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s baseline to Node.js 24, refreshes CI/publish workflows accordingly, and corrects retry backoff documentation to match the implementation.
Changes:
- Bump package major version to
8.0.0and setengines.nodeto Node 24+. - Update GitHub Actions workflows for CI, coverage reporting, and release/beta publishing; remove the dedicated publish-beta workflow.
- Clarify/correct exponential backoff documentation (and add concrete timing examples) and modernize a few internal constants/usages (e.g.,
Infinity).
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/retry.ts |
Updates defaults/formatting and clarifies backoff comments to match actual behavior. |
src/retry.spec.ts |
Adjusts tests for newer Node APIs and refactors some iteration/formatting. |
src/options.ts |
Copyright year update. |
src/index.ts |
Copyright year update. |
src/error.ts |
Formats Error construction (with cause) and updates copyright year. |
SECURITY.md |
Updates supported major version range to >= 8.0. |
README.md |
Corrects backoff formula explanation and adds concrete timing examples. |
package.json |
Major version bump, Node engine bump, dependency/devDependency updates, script updates. |
LICENSE.txt |
Copyright year update. |
.github/workflows/publish.yml |
Consolidates release and PR beta publishing into one workflow; updates action versions and publishing flow. |
.github/workflows/publish-beta.yml |
Removes the now-redundant beta publish workflow. |
.github/workflows/coverage.yml |
Splits coverage into base/pr jobs with artifact-based reporting and adds concurrency control. |
.github/workflows/codeql-analysis.yml |
Updates CodeQL action versions. |
.github/workflows/ci.yml |
Updates Node matrix and action versions; normalizes step naming/env. |
.github/workflows/check-published-scheduled.yml |
Updates checkout/action usage and simplifies the job steps. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Coverage after merging node24 into main will be
Coverage Report
|
||||||||||||||||||||||||||||||||||||||
|
Beta Published - Install Command: |
le-cong
reviewed
Aug 27, 2026
le-cong
left a comment
le-cong
left a comment
There was a problem hiding this comment.
looks good, just a very minor comment
| uses: actions/checkout@v7 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
| - name: Install Node.js |
There was a problem hiding this comment.
is "Install Node.js" step removed intentionally?
Contributor
Author
There was a problem hiding this comment.
yeah its not used
|
❌ PR review status - not all reviewers have approved - 1 approved - 1 outstanding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27 and fixes #18.